A lot of links have become outdated over the years due to Drupal URL schema changes, most notably of course the prettified paths for issues. I also noticed that some links to documentation still link to the D7 version.

CommentFileSizeAuthor
#8 2998853-8--update_links.patch7.53 KBdrunken monkey
#8 2998853-8--update_links--interdiff.txt20.97 KBdrunken monkey
#4 2998853-4--update_links.patch19.6 KBdrunken monkey
#4 2998853-4--update_links--interdiff.txt4.63 KBdrunken monkey
#2 2998853-2--update_links.patch23.89 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2998853-2--update_links.patch23.89 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

This patch seems to include a lot of things that are unrelated. Can you reroll it without the other changes?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2998853-4--update_links--interdiff.txt4.63 KB
new 2998853-4--update_links.patch19.6 KB

Oops, sorry! And thanks for spotting!
I thought I’d taken care not to include those, but apparently not.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Needs work 
+++ b/README.txt
@@ -104,7 +104,7 @@ read the "Drupal 8 backwards compatibility and internal API policy" [6] and the
-[7] https://www.drupal.org/node/2871549
+[7] https://www.drupal.org/project/search_api/issues/2871549

+1 in respect to updating the documentation URLs, but -1 in respect to changing the issue urls. the ../node/[number] format will always work, where the ../project/[name]/[number] format will stop working if an issue is moved between projects for any reason. In my opinion all specific issue urls should be changed to the generic ../node/[number] format instead.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

+1 in respect to updating the documentation URLs, but -1 in respect to changing the issue urls. the ../node/[number] format will always work, where the ../project/[name]/[number] format will stop working if an issue is moved between projects for any reason.

That’s (fortunately) not true, Drupal.org automatically adds redirects when such a URL alias changes.
Do you still stand by your opinion? In that case we’d need some arbiter (Joris?).

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

I'm going to be really unhelpful here, I don't really care either way. I personally use drupal.org/i/[nid]. That is the shortest :)

However, I am aware that adding yet another way is bad.

I do think that is not helpful that when we link to an issue with (/search_api/[id]/) and it ends up in another queue.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2998853-8--update_links--interdiff.txt20.97 KB
new 2998853-8--update_links.patch7.53 KB

Being shorter is indeed a good point, and I guess even though links to moved issues will still work as an alias, they won’t be the canonical link anymore, defeating the whole purpose of the rename.
So, on reflection, I guess let’s go with the /node/[NID] links after all.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

  • drunken monkey committed fda2ec3 on 8.x-1.x 
    Issue #2998853 by drunken monkey, borisson_, legolasbo: Updated links...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Alright, thanks for the feedback!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.