Similar as #2790693: "Performance" tab rendered twice in Performance section, advagg_validator/advagg_validator.links.task.yml also duplicate define the core's 'Performance' tab and so it display twice under drupal 8.6.0.

CommentFileSizeAuthor
#4 2998702-4.jpg34.91 KBosab
#4 advagg-8_x-3_x-remove_duplicates_performance_tab-2998702-4.patch714 bytesosab
#2 advagg-8.x-3.x-remove_redundant_performance_tab-2998702-2.patch666 byteshswong3i

Comments

hswong3i created an issue. See original summary.

hswong3i’s picture

hswong3i commented
Status: Needs work » Needs review
StatusFileSize
new advagg-8.x-3.x-remove_redundant_performance_tab-2998702-2.patch666 bytes
idebr’s picture

idebr commented
Title: Fixup #2790693: "Performance" tab rendered twice in Performance section » Advagg Validator duplicates Core's "Performance" tab in Performance section
Status: Needs review » Reviewed & tested by the community

Thanks hswong3i, this fixes the duplicate tab at /admin/config/development/performance.

osab’s picture

osab commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new advagg-8_x-3_x-remove_duplicates_performance_tab-2998702-4.patch714 bytes
new 2998702-4.jpg34.91 KB

Tested on 8.6.2 unsuccessfully. So, I've made the same change as hswong3i but in advagg/advagg.links.task.yml file.

Status: Needs review » Needs work

The last submitted patch, 4: advagg-8_x-3_x-remove_duplicates_performance_tab-2998702-4.patch, failed testing. View results

osab’s picture

osab commented
Status: Needs work » Reviewed & tested by the community

Excuse me, I hurried up with the fix. I should check on the branch 8.x-3.x-dev. But I was on 8.x-3.5 where the file advagg.links.task.yml still has advagg.performance link.
So, for 8.x-3.x-dev the patch #2 works properly. Thanks, hswong3i!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

The #2 works for me!

advagg-8.x-3.x-remove_redundant_performance_tab-2998702-2.patch

  • thalles committed edbdf8e on 8.x-3.x authored by osab 
    Issue #2998702 by osab, hswong3i, idebr, thalles: Advagg Validator...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Fixed!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.