FILE: ...taxonomy_menu_trails/src/TaxonomyMenuTrailsBreadcrumbBuilder.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
   3 | ERROR   | [x] There must be one blank line after the namespace
     |         |     declaration
  85 | WARNING | [ ] Line exceeds 80 characters; contains 81
     |         |     characters
  90 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  93 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  96 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 101 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 104 | WARNING | [ ] Line exceeds 80 characters; contains 86
     |         |     characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...rupal8/modules/contrib/taxonomy_menu_trails/js/node-type-form.js
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
  7 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing
    |       |     parentheses
  9 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 15 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing
    |       |     parentheses
 19 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing
    |       |     parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...odules/contrib/taxonomy_menu_trails/taxonomy_menu_trails.install
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  9 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
    |         |     for xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
    |         |     "* Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
 13 | ERROR   | [x] Expected 1 newline at end of file; 3 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...modules/contrib/taxonomy_menu_trails/taxonomy_menu_trails.module
----------------------------------------------------------------------
FOUND 14 ERRORS AND 1 WARNING AFFECTING 15 LINES
----------------------------------------------------------------------
   6 | ERROR   | [x] There must be exactly one blank line after the
     |         |     file comment
  23 | ERROR   | [ ] Missing parameter comment
  24 | ERROR   | [ ] Missing parameter comment
  25 | ERROR   | [ ] Missing parameter comment
  27 | ERROR   | [ ] Type hint "array" missing for $form
  73 | ERROR   | [x] Expected 1 space after "=>"; 2 found
  78 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, colons, question marks, or
     |         |     closing parentheses
  97 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 136 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 139 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 151 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: '</p>'
 157 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 158 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 159 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 160 | ERROR   | [x] Array closing indentation error, expected 2
     |         |     spaces but found 4
----------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Comments

Aston Victor created an issue. See original summary.

astonvictor’s picture

Status: Active » Needs review
StatusFileSize
new12.57 KB
nehajyoti’s picture

Status: Needs review » Needs work

The patch doesn't get apply cleanly against 8.x-1.x branch.

nitin_lama’s picture

Assigned: Unassigned » nitin_lama
nitin_lama’s picture

Status: Needs work » Needs review
StatusFileSize
new12.45 KB

Updated patch for 8.x-1.x

abhijith s’s picture

Applied patch #5.It fixes the CS issues.

nitin_lama’s picture

Assigned: nitin_lama » Unassigned
Arturo-q’s picture

Status: Needs review » Reviewed & tested by the community

Hello, In deed, the patch #5 solve the CS errors, changing status to RTBC.

  • nehajyoti committed bdad739 on 8.x-1.x
    Issue #2997688 by AstonVictor, nitin_lama, Abhijith S, nehajyoti,...
nehajyoti’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.