The CasValidator validates the ticket coming from CAS for both versions (1 and 2). In doing so, it creates a CasPropertyBag with the data coming from CAS (username and attributes mainly). However, some CAS servers return data in a different way, have extra keys etc and that data might need to be used.
What we should do is create a new event that can be dispatched at that moment to allow other modules to intercept this process and add data into the property bag according to their specific needs.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | interdiff.txt | 3.23 KB | bkosborne |
| #18 | 2997099-18.patch | 13.05 KB | bkosborne |
| #16 | 2997099-16.patch | 13.06 KB | ieguskiza |
| #13 | 2997099-13.patch | 13.08 KB | ieguskiza |
| #11 | 2997099-11.patch | 13.09 KB | ieguskiza |
Comments
Comment #2
ieguskiza commentedI uploaded a patch to provide the described functionality
Comment #4
ieguskiza commentedTried fixing failing tests and added a new test.
Comment #5
upchuk commentedComment #8
bkosborneThis is a dup of #2988477: Allow altering property bag from validate response. and both patches use the same method to resolve, but this one has tests, so I will close that one in favor of this one and give credit to that issue creator as well.
I'm curious what type of data is actually in that CAS validation response that's needed. I tried to follow the CAS protocol as closely as possible and I don't think the protocol accounts for such extra information that could be passed in the validation response. That said, this is obviously a needed feature so I support it going in.
Comment #9
upchuk commentedAh, did not find that issue.
Yeah we are dealing with a CAS response that returns the email for example in some weird location, not following the CAS protocol properly I guess. So I assume there are other cases out there as well. So we created this solution to allow various uses cases.
Comment #10
bkosborneOk. I will review this weekend. Thanks for providing the patch.
Comment #11
ieguskiza commentedHopefully this patch will be green, I found out some very stupid mistakes I left in the previous patch (and the tests are green in my local installation).
Comment #13
ieguskiza commentedSo php5.6 doesn't allow to type hint scalar types :(
Hopefully this makes the patch green.
Comment #14
ieguskiza commentedComment #16
ieguskiza commentedA bit hard to debug this since I use php7 :( Sorry for all the noise.
Comment #17
upchuk commentedI tested this, works well. Now the CAS server can return unicorns, modules can read that as they please and turn it into attributes.
Comment #18
bkosborneThanks for all the work! Only modification I made was to rename the event from CasAfterValidateEvent to CasPostValidateEvent, which matches the naming convention used for the other events (which use Pre instead of Before).
Will commit once these tests pass.
Comment #20
bkosborne