Problem/Motivation

The README.md file links to the module's help page.

Proposed resolution

Change the link to the module's project page on drupal.org.

CommentFileSizeAuthor
#10 2996607-10.patch533 byteshardikpandya
#10 interdiff_5-10.txt555 byteshardikpandya
#5 gender-n2996607-5.patch531 bytesdamienmckenna
#5 gender-n2996607-5.interdiff.txt555 bytesdamienmckenna
#2 gender_field_readme-2996607-2.patch533 bytesjohnny_aroza
#4 interdiff_2-4.txt1.28 KBjohnny_aroza
#4 gender_field_readme-2996607-4.patch1.45 KBjohnny_aroza

Comments

alexdmccabe created an issue. See original summary.

johnny_aroza’s picture

johnny_aroza commented
Status: Active » Needs review
StatusFileSize
new gender_field_readme-2996607-2.patch533 bytes

alexdmccabe i have updated the README.md link to the module's project page on drupal.org.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Needs work 
+++ b/README.md
@@ -7,5 +7,6 @@ information of individuals.
+a guide.

Please follow the guidelines in https://www.drupal.org/docs/develop/documenting-your-project/readme-template to create the README file.

johnny_aroza’s picture

johnny_aroza commented
Status: Needs work » Needs review
StatusFileSize
new gender_field_readme-2996607-4.patch1.45 KB
new interdiff_2-4.txt1.28 KB

imalabyamade the changes according to the template

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new gender-n2996607-5.interdiff.txt555 bytes
new gender-n2996607-5.patch531 bytes

Patch #4 had a minuscule mistake in that it had unnecessary spaces at the end of the two lines. This patch removes the unwanted spaces but is otherwise identical.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented

What does everyone think of changing this so instead of putting the link in an inline codeblock, it instead formats the link as an actual link? I'm asking because it feels unnecessary, but technically I think it's more appropriate to do so.

So instead of:

See the gender field module's project page at https://www.drupal.org/project/gender after installing for more details and a guide.

We'd see:

See the gender field module's project page after installing for more details and a guide.

There's a guide on how to create links in Markdown here: https://daringfireball.net/projects/markdown/syntax#link

sparklingrobots’s picture

sparklingrobots
she/they
Primary language English
Location United States
commented

I like the suggestion, @alexdmccabe.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

Agreed!
Let's replace this URL by a proper link to the page.

hardikpandya’s picture

hardikpandya commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_5-10.txt555 bytes
new 2996607-10.patch533 bytes
alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Status: Reviewed & tested by the community » Fixed

Applied and back-ported to 7.x.-2.x.

Thanks everyone!

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Issue tags: -vcd2018, -Novice

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.