Needs work
Project:
Feeds
Version:
8.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Aug 2018 at 18:45 UTC
Updated:
24 Oct 2019 at 19:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
megachrizWork in progress patch. About the implementation I don't like that the different statuses of items (created, updated, etc.) are hard-coded. An extension module cannot add another type of status this way (for example: unpublished, blocked, etc.).
Comment #3
megachrizThis is a more advanced implementation, allowing contrib modules to define new states in a *.feeds_states.yml file.
Needs tests, but first see what would break.
Comment #4
megachrizAllowing to set custom properties on \Drupal\feeds\State.
Comment #5
megachrizThis doesn't pass tests yet, but it should fix the infite loop that occurred when deleting imported items.
Comment #6
bogdog400 commentedMy stock version of 8 shows the progress bar bouncing left and right as if it can't make up its mind how much data is imported. One second it is 90% and the next second it is 14%. It bounced back and forth until it's done.
Comment #7
megachrizSince the advanced, flexible solution isn't able to pass tests, I supply a slightly modified version of the patch in #2 here, so this feature can be included for the next release (if it still passes tests). This version doesn't change \Drupal\Feeds\State, so all logic for this feature now happens solely in FeedViewBuilder.
This feature has proven me useful a lot: on a large import running during cron I can see early on what's happening and act on errors earlier.
Comment #9
megachrizCommitted #7 with a coding standard fixed.
Leaving issue open for more advanced solution and tests.