An example: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Could you add exclude phrase:

For Safari this phrase is Chrome)

CommentFileSizeAuthor
#2 user_agent_class-exclude-trigger-2996222-12754324.patch9.71 KBartsays

Comments

IreneV created an issue. See original summary.

artsays’s picture

artsays commented
Status: Active » Needs review
StatusFileSize
new user_agent_class-exclude-trigger-2996222-12754324.patch9.71 KB

Created exclude field.

An example:
Safari User Agent:
Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/534.57.2 (KHTML, like Gecko) Version/5.1.7 Safari/534.57.2

Chrome User Agent contains Sarari trigger:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

For correct detect "Safari" by default trigger "Safari" need to add in exclude field "Chrome" because you can see "Chrome User Agent" contains Safari phrase

extatic’s picture

extatic commented

The current patch works well with backend detection, but there is still some issue when JS-detection option selected.

extatic’s picture

extatic commented

Finally it works well with both of the methods, the browser cache made me to write previous comment. Sorry and tnx for the fix.

extatic’s picture

extatic commented
Status: Needs review » Reviewed & tested by the community
artsays’s picture

artsays commented
Status: Reviewed & tested by the community » Fixed

Thank you for your review!

artsays’s picture

artsays commented
Status: Fixed » Closed (fixed)