There are some CS issues.

CommentFileSizeAuthor
#7 coding-standard-2995816-7.patch20.96 KBDeepthi kumari
#4 2995816_password_strength_cs_fix_2.patch14.37 KBastonvictor
#2 2995816_password_strength_cs_fix.patch11.34 KBastonvictor

Issue fork password_strength-2995816

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Aston Victor created an issue. See original summary.

astonvictor’s picture

astonvictor commented
Status: Active » Needs review
StatusFileSize
new 2995816_password_strength_cs_fix.patch11.34 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2995816_password_strength_cs_fix.patch, failed testing. View results

astonvictor’s picture

astonvictor commented
Status: Needs work » Needs review
StatusFileSize
new 2995816_password_strength_cs_fix_2.patch14.37 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2995816_password_strength_cs_fix_2.patch, failed testing. View results

Deepthi kumari’s picture

Deepthi kumari commented
Assigned: Unassigned » Deepthi kumari
Deepthi kumari’s picture

Deepthi kumari commented
Status: Needs work » Needs review
StatusFileSize
new coding-standard-2995816-7.patch20.96 KB

Applied Patch. Please review

Status: Needs review » Needs work

The last submitted patch, 7: coding-standard-2995816-7.patch, failed testing. View results

astonvictor’s picture

astonvictor commented
Version: 8.x-2.0-alpha2 » 8.x-2.x-dev
astonvictor’s picture

astonvictor commented
Status: Needs work » Reviewed & tested by the community

Looks ok for me.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Needs work

There's 2 test fails, so this needs work.

Indra patil made their first commit to this issue’s fork.

indrapatil’s picture

indrapatil commented
Assigned: Deepthi kumari » indrapatil

Indra patil opened merge request !4

indrapatil’s picture

indrapatil commented
Assigned: indrapatil » Unassigned
Status: Needs work » Needs review

nord102 made their first commit to this issue’s fork.

nord102 opened merge request !7

nord102 closed merge request !4

nord102 closed merge request !7

nord102 opened merge request !8

nord102’s picture

nord102
he/him
Primary language English
commented

I've created a new MR based on the latest release and leveraging the work done in #7. I have closed the other MR as it was out of date.

One thing I noticed is that PasswordStrengthMatcherPluginManager.php references two classes that don't exist anymore:

  • Plugin/PasswordStrengthMatcher
  • Drupal\password_strength\PasswordStrengthMatcherInterface

So that's something we should probably fix as well