Problem/Motivation

The config entity annotations for OgMenu include a collection link template. This link template for '/admin/structure/visibility_group' leads to a 404, page not found. Typically the collection route is for the list builder.

Proposed resolution

Swap out the overview-form link for the collection link template.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork og_menu-2994891

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heddn created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Postponed
Related issues: +#2992044: Add a list builder for OG Menu instances and replace the custom OverviewMenuInstances form

Blocking this on #2992044: Add a list builder for OG Menu instances and replace the custom OverviewMenuInstances form which is adding the list builder.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Postponed » Active

Still a live bug. OgMenu.php:44 still declares "collection" = "/admin/structure/visibility_group" a dead, unrelated path (looks like leftover copy-paste). The actual working listing route is entity.ogmenu.collection at /admin/structure/menu/ogmenu (og_menu.routing.yml:50-56). It was postponed in 2018 pending #2992044: Add a list builder for OG Menu instances and replace the custom OverviewMenuInstances form, but the fix doesn't need that: just correct or drop the bogus collection link key. One-line fix, worth porting to 2.x.

joelpittet opened merge request !29

  • joelpittet committed 724361a2 on 2.x 
    fix: #2994891 OgMenu collection link template is a 404

By: heddn
By:...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Fixed

Thank you, I have merged this into 2.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • joelpittet committed 191efb66 on 2.x 
    fix: #2994891 missed the fix for the collection on the attribute version

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.