According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new327 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

alonaoneill’s picture

volkswagenchick’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. All the projects listed as dependencies on the Extend page for the module are now listed as dependencies. The dependency namespacing aligns with Drupal documentation standards.

Patch applied via simplytest.me

Marking as RTBC

chipway’s picture

Status: Reviewed & tested by the community » Needs work

Hi,
Dependencies are recursive, so please Do not add user, system and filter.

alonaoneill’s picture

Status: Needs work » Needs review
StatusFileSize
new272 bytes

I uploaded a patch that removes user, system and filterfrom the dependency namespacing in the .info.yml file.
Thanks!

chipway’s picture

Status: Needs review » Reviewed & tested by the community

Thanks Alona,

Looks OK for me.

jerdavis’s picture

Committed and pushed, thanks!

jerdavis’s picture

Status: Reviewed & tested by the community » Fixed

  • jerdavis committed 8b27c1d on 8.x-3.x
    Issue #2994142 by alonaoneill: Dependency namespacing in .info.yml file
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.