field_tags is used on both the Recipe and Article type.
On the Article type, the examples in the help text for this field are nothing like the tags you would actually use on this website:
We should change these examples to be culinary related ones that indicate how this field would actually be used.
The recipe content also has field_tags, but here it has no help. We should reimplement the help text from article once updated here.
Update help text on both content types.
UI will have more appropriate help text.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 2991573-help-text-for-field-tags.patch | 1.35 KB | ltrain |
| #12 | 2991573-help-text-for-field-tags.patch | 1.35 KB | imalabya |
| #9 | Tags___Umami_Food_Magazine.png | 48.6 KB | eli-t |
| #7 | 2991573-help-text-for-field-tags.patch | 1.39 KB | ltrain |
| #4 | 2991573-help-text-for-field-tags.patch | 1.34 KB | ltrain |
Comments
Comment #2
msankhala commentedWhat about this:
field_tag description for the article content type for Umami profile:
Enter a comma-separated list. For example Cold Drink, Hot Beverages, Vegetarian etc.field_tag description for the recipe content type for Umami profile:
we can use the same description as the article content type or something like:
Enter a comma-separated list. For example Egg, Vegetarian, Dessert etc.Comment #3
ltrainPicking this up as part of Drupal North Sprint Day 2018.
Comment #4
ltrainAdded description "Enter a comma-separated list. For example: herbs, vegetarian, chocolate brownies" for the field in both content types.
Comment #5
ltrainComment #6
eli-tThanks for working on this - looks good, but I'd suggest the examples use sentence case, to match the tags created at install time.
Comment #7
ltrainTaking another shot at it!
Enter a comma-separated list. For example: vegetarian, chocolate brownies, "French fries, cooking techniques"
Comment #8
ltrainComment #9
eli-tThanks for taking another shot. We're not quite there yet though. By "sentence case" I meant that the tags should have the first letter of the first word capitalised, to match how they are listed in the Tag listing:
See https://en.wikipedia.org/wiki/Capitalization#Sentence_case.
Also, the example of "Cleveland, Ohio" in the original tags help text is to demonstrate how you can add a tag with a comma in to a comma separated list. This patch adapts that to "French fries, cooking techniques" which is odd to have as a single tag. I'd suggest that all the examples that we use in the description should exist in the tag list created when we install, especially as they aren't set to auto create for recipe (I'll raise a follow up for that).
Comment #10
eli-tComment #11
ltrainPoint taken with regard to the capitalization!
I had thought you were requesting that one of the terms include a use of comma, for which I tried to come up with a food-related case - I took this from the index of a cookbook, meaning "Cooking techniques for french fries".
If I go back to the previous list but with capitalization, will that work?
Comment #12
imalabyaAdded a set of Tags from the list.
Baking, Cocktail party, "Healthy, Vegetarian"for ArticlesAlcohol free, Herbs, "Pastry, Seasonal"for RecipesComment #13
joachim commented"Healthy, Vegetarian" doesn't make sense as a single tag. It should be two tags surely.
I don't think think there is an equivalent culinary term we can use that contains a comma to demonstrate how to escape a comma.
Comment #14
eli-t@joachim +1. That was the point I was trying to make in #9
Comment #15
ltrainEnter a comma-separated list. For example: Vegetarian, Chocolate brownies, Appetizers
Comment #16
joachim commentedLGTM.
We could open a follow-up to think of a suitable culinary term that contains a comma.
Comment #18
eli-tFail looks unrelated. Putting back to Needs Review to trigger testbot.
Comment #19
eli-tTests passed after being retriggered in #18.
Patch looks good and covers what was required in the issue summary - we have culinary examples of tags when editing recipes and articles.
Applied and successfullt manually tested using SimplyTest.me.
Returning to RTBC.
Comment #20
alexpottCommitted and pushed 019f7e10b0 to 8.7.x and ebeefc8197 to 8.6.x. Thanks!