There are situations where I need to take my site offline, and when I do this, I also stop the node.js app.

However, when cron runs, the NodejsSubscriber responds to the KernelEvents::TERMINATE event and tries to send messages. Which, of course, since my node.js app is also offline, will simply fail and throw all sorts of errors.

I believe we can alleviate this quite simply by not trying to connect to the node.js app to send messages when the site is offline.

CommentFileSizeAuthor
#2 nodejs-ignore-messages-offline-2991533-2.patch1.45 KBjoelstein

Comments

joelstein created an issue. See original summary.

joelstein’s picture

joelstein commented
Status: Active » Needs review
StatusFileSize
new nodejs-ignore-messages-offline-2991533-2.patch1.45 KB

Here's a patch which does the trick.

  • beejeebus committed 9255131 on 8.x-1.x 
    Issue #2991533 by joelstein, beejeebus: Don't send messages when site is...
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

thanks! i went with a version of this that checks site maintenance mode at a point that all communication with the node.js server goes through.

joelstein’s picture

joelstein commented

Great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.