Closed (fixed)
Project:
Printer, email and PDF versions
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Aug 2018 at 14:40 UTC
Updated:
23 Jun 2022 at 08:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
paulvandenburg commentedThis adds support for v7+ of mpdf.
It however does expect that composer install has been run in the mpdf library.
The problem is that since v7 there is no longer a version number inside the library, so it is hard to detect the used version.
Which is needed to switch between the 7+ and 6- logic for the library.
But this solution works.
Comment #3
paulvandenburg commentedI've discovered another issue which is actually more related to how print_pdf handles library tool_dirs.
When a library defines a tool_dir in its info hook, print_pdf will check if it exists and is writable in its requirements hook.
However it will make no attempt to create such a folder, even when it has the permissions to do so.
As a result it keeps complaining on your status page.
The simple solution for now is to remove the tool_dir for version 7.x of mpdf. It no longer uses that tool_dir.
I've also fixed the version function where I made a small mistake for detecting 7.x versions of mpdf.
Comment #4
tvoesenek commentedTested locally on a php 7.1 site, works good.
Comment #6
jcnventuraThanks!