Remove hard coded dependency on the onecol layout.

Working on this

With update path tests.

Idk that this needs a UI in core, but one could be written from contrib.

Aha, yeah this does need accounting for during install. Thanks for the thorough review!

1) :)
2) I am quite the opposite, since by default exception messages get concatenated into a larger sentence!
3) Hah, I wrestled with this a bunch. Feel like I'm being too tricky here. Probably should change this
4) Yeah I wasn't sure the best way to check this, I c/p'd this from another test.
5) Yep, NW for that

Not personally working on this right now, hopefully I'll have time next week.

#3030647: Do not add a section when editing an empty layout, or differentiate between new layouts and existing empty layouts removes one of the main usages of the onecol layout.

Here's a straight reroll of the old patch.

Rerolled.

The layout is now called layout_twocol_section. Also updated the update hook name.

Looks good still, need someone to review!

+++ b/core/modules/layout_builder/src/Entity/LayoutBuilderEntityViewDisplay.php
@@ -453,7 +453,8 @@ public function setComponent($name, array $options = []) {
-      $this->appendSection(new Section('layout_onecol'));
+      $default_layout_id = \Drupal::config('layout_builder.settings')->get('default_layout_id');
+      $this->appendSection(new Section($default_layout_id));

+++ b/core/modules/layout_builder/src/Plugin/Field/FieldType/LayoutSectionItem.php
@@ -80,7 +80,8 @@ public static function schema(FieldStorageDefinitionInterface $field_definition)
-    $values['section'] = new Section('layout_onecol');
+    $default_layout_id = \Drupal::config('layout_builder.settings')->get('default_layout_id');
+    $values['section'] = new Section($default_layout_id);

I wonder if here we should add 'layout_onecol' as the default when the setting doesn't exist. It would maintain the existing functionality where sites somehow failed to install the settings, deleted it or were between updates somehow.

Other than that, LGTM.

NW for #15

Not uploading Interdiff..Not sure why it was showing wrong changes. However done the fix mentioned in #15 and re-rolled against 8.9.x

Thanks!

1. +++ b/core/modules/layout_builder/layout_builder.install
   @@ -136,3 +137,24 @@ function layout_builder_update_8602() {
   +/**
   + * Set a default layout ID.
   + */
   +function layout_builder_update_8801() {
   
   +++ b/core/modules/layout_builder/src/Entity/LayoutBuilderEntityViewDisplay.php
   --- a/core/modules/layout_builder/src/Plugin/Field/FieldType/LayoutSectionItem.php
   +++ b/core/modules/layout_builder/src/Plugin/Field/FieldType/LayoutSectionItem.php
   
   +++ b/core/modules/layout_builder/tests/src/Functional/Update/DefaultLayoutIDUpdatePathTest.php
   @@ -0,0 +1,77 @@
   +      __DIR__ . '/../../../../../system/tests/fixtures/update/drupal-8.4.0.bare.standard.php.gz',
   

   This needs to use an 8.8.x update file and I think given we're adding an update function this should target 8.9.x

2. +++ b/core/modules/layout_builder/layout_builder.install
   @@ -136,3 +137,24 @@ function layout_builder_update_8602() {
   +    if (empty($layout_ids)) {
   +      throw new UpdateException('No layout plugins available');
   +    }
   

   This makes me realise that we've introduced a dependency on config entities from the simple config. If you delete the default layout then the config is invalid.

   I ponder if we should do this in a different way. Can we have a default flag on the config entity instead?

currently working on it .......

Please find the updated patch .......