Please check code standard issues and fix

CommentFileSizeAuthor
#15 sliderwidget-remove-idea-path-fixed-coding-standards-2989804-15.patch55.2 KBysamoylenko
#14 sliderwidget-remove-idea-path-fixed-coding-standards-2989804-14.patch95.83 KBysamoylenko
#12 codestyle-css-2989804-12.patch19.78 KBextatic
#11 sliderwidget-remove-phpstorm-folder-2989804-8.patch.diff27.31 KBIreneV
#9 sliderwidget-codestyle-2989804-8.patch.diff19.78 KBIreneV
#8 sliderwidget-codestyle.patch19.77 KBIreneV
#7 2989804-7.patch537 bytesbhanuprakashnani
#6 2989804-6.patch3.1 KBbhanuprakashnani
#5 2989804-5.patch1.22 KBbhanuprakashnani
#4 2989804-4.patch529 bytesbhanuprakashnani
#3 2989804-3.patch446 bytesbhanuprakashnani
#2 2989804-2.patch1.59 KBbhanuprakashnani
code_sniffer_issues.txt16.57 KBIreneV

Comments

IreneV created an issue. See original summary.

bhanuprakashnani’s picture

bhanuprakashnani commented
Assigned: Unassigned » bhanuprakashnani
StatusFileSize
new 2989804-2.patch1.59 KB

I have changed the code for a single file. I will send separate patches for each file errors. Please review them. Thank you.

bhanuprakashnani’s picture

bhanuprakashnani commented
StatusFileSize
new 2989804-3.patch446 bytes

Initialised variable $value2

bhanuprakashnani’s picture

bhanuprakashnani commented
StatusFileSize
new 2989804-4.patch529 bytes

Indentations in CSS files

bhanuprakashnani’s picture

bhanuprakashnani commented
StatusFileSize
new 2989804-5.patch1.22 KB

Wrote the README file as per the Drupal Standards please review.

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Active » Needs review
StatusFileSize
new 2989804-6.patch3.1 KB

Changed the CSS colors to lowercase.

bhanuprakashnani’s picture

bhanuprakashnani commented
StatusFileSize
new 2989804-7.patch537 bytes

sliderwidget.module errors are fixed. Please review.

IreneV’s picture

IreneV commented
StatusFileSize
new sliderwidget-codestyle.patch19.77 KB

Fixes according to Drupal code sniffer

IreneV’s picture

IreneV commented
StatusFileSize
new sliderwidget-codestyle-2989804-8.patch.diff19.78 KB

Fixed patch

IreneV’s picture

IreneV commented
IreneV’s picture

IreneV commented
StatusFileSize
new sliderwidget-remove-phpstorm-folder-2989804-8.patch.diff27.31 KB

Remove phpstorm folder

extatic’s picture

extatic commented
StatusFileSize
new codestyle-css-2989804-12.patch19.78 KB

This patch includes fixes in comment 9 + css color codes refactored to be in lower case.

IreneV’s picture

IreneV commented
ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new sliderwidget-remove-idea-path-fixed-coding-standards-2989804-14.patch95.83 KB

This patch includes previous code standards patches, removing ".idea/" folder and also has fixes for Drupal and DrupalPractice CodeSniffer Standards.

ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new sliderwidget-remove-idea-path-fixed-coding-standards-2989804-15.patch55.2 KB

I've updated the patch, please review it.

IreneV’s picture

IreneV commented
IreneV’s picture

IreneV commented
IreneV’s picture

IreneV commented

Thanks for fixing

IreneV’s picture

IreneV commented
Status: Needs review » Fixed
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Apply Drupal code standarts » Apply Drupal coding standards
IreneV’s picture

IreneV commented
Version: » 8.x-1.x-dev
Status: Fixed » Closed (fixed)