Problem/Motivation

We want to be able to replicate our management forms with views.
It will be helpful to refactor our tests as possible so we can reuse our existing bulk management tests for this views and ensure we can replicate those UIs.

Proposed resolution

Refactor our tests as possible so we can reuse our existing bulk management tests for this views and ensure we can replicate those UIs.

Remaining tasks

Patch

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#14 2989345-refactor-tests-14.patch349.61 KBpenyaskito
#14 2989345-refactor-tests.interdiff.12-14.txt4.12 KBpenyaskito
#12 2989345-refactor-tests-12.patch345.48 KBpenyaskito
#12 2989345-refactor-tests.interdiff.10-12.txt11.7 KBpenyaskito
#10 2989345-refactor-tests-10.patch333.78 KBpenyaskito
#10 2989345-refactor-tests.interdiff.8-10.txt1.66 KBpenyaskito
#8 2989345-refactor-tests-8.patch332.12 KBpenyaskito
#8 2989345-refactor-tests.interdiff.6-8.txt36.48 KBpenyaskito
#6 2989345-refactor-tests-6.patch327.1 KBpenyaskito
#5 2989345-refactor-tests-5.patch74.87 KBpenyaskito
#4 2989345-refactor-tests-4.patch63.52 KBpenyaskito
#2 2989345-refactor-tests-2.patch62.51 KBpenyaskito

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2989345-refactor-tests-2.patch62.51 KB

Refactored \Drupal\Tests\lingotek\Functional\LingotekNodeBulkTranslationTest.
If this is still green we can do massive automated refactoring.

Status: Needs review » Needs work

The last submitted patch, 2: 2989345-refactor-tests-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2989345-refactor-tests-4.patch63.52 KB

Fixed errors.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 2989345-refactor-tests-5.patch74.87 KB

Added another bulk test passing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 2989345-refactor-tests-6.patch327.1 KB

Bunch of automatic replacements.

Status: Needs review » Needs work

The last submitted patch, 6: 2989345-refactor-tests-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2989345-refactor-tests.interdiff.6-8.txt36.48 KB
new 2989345-refactor-tests-8.patch332.12 KB

Some code standards and phpdoc.
Fixed the errors.

Status: Needs review » Needs work

The last submitted patch, 8: 2989345-refactor-tests-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2989345-refactor-tests.interdiff.8-10.txt1.66 KB
new 2989345-refactor-tests-10.patch333.78 KB

So the refactoring uncovered a bug in the recently included render elements. Isn't it beautiful?

Status: Needs review » Needs work

The last submitted patch, 10: 2989345-refactor-tests-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2989345-refactor-tests.interdiff.10-12.txt11.7 KB
new 2989345-refactor-tests-12.patch345.48 KB

And now the bug is in the tests. Cleaned up templates for extra spacing while we are at it.

Status: Needs review » Needs work

The last submitted patch, 12: 2989345-refactor-tests-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2989345-refactor-tests.interdiff.12-14.txt4.12 KB
new 2989345-refactor-tests-14.patch349.61 KB

Now other tests that depended on the bad spacing failed. This makes all of the green.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Tests passed as expected.

  • penyaskito committed 83597bc on 8.x-2.x 
    Issue #2989345 by penyaskito: Refactor tests as possible so we can reuse...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed 83597bc and pushed to 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.