Incompatibility with inline entity form

Broken by #2878359: Field groups are not compatible with field layout - hate when there are no tests for a feature and hence it gets broken by other changes

Experiencing the same issue.

Debugging this I noticed #process callbacks don't seem to be called for Inline Entity Forms.

A snippet from \Drupal\Core\Form\FormBuilder::doBuildForm():

if (isset($element['#process']) && !$element['#processed']) {
  foreach ($element['#process'] as $callback) {
    $complete_form = &$form_state->getCompleteForm();
    $element = call_user_func_array($form_state->prepareCallback($callback), [&$element, &$form_state, &$complete_form]);
  }
  $element['#processed'] = TRUE;
}

The field_group_form_process callback is added while the above process callbacks are already being processed, and thus is never called.

The patch attached does fix my issue, but I'm not familiar with Field Group & Inline Entity Form all too well - I would suggest someone more experienced to look at this.

So far it is working for me, at least resolved the immediate issue of the ief not rendering the field group ( and worse, totally mangling my form ). Great job.

+1 for #3

While patch #3 works fine, I'm not sure that's the best approach.

Thanks, #3 works for me as well. I'm no coder = cannot review.

Setting to NW as tests are missing as mentioned in #2.

#3 worked for me too.

Not sure why it's not the best approach, but it doesn't seem too harmful. I'm happy with anything that makes IEF work for fringe cases.

#3 worked for me too

#3 is working for us.

FYI: I needed #3 for #2907094: Make paragraphs module working with field_group version 3.x with support for the field_layout module to work in paragraphs.

#3 patch also seems to fix the issue with inline entity forms after updating this from beta1 to rc1

I've got this issue, too, and #3 fixed it -- don't know enough to comment on the concerns expressed in the thread, but very happy with the outcome so far! Thank you! (And thank you, @Anybody, for mentioning it on the referenced paragraphs issue thread!)

added current state to the summary:

• we have a patch (#3) with +10 worksforme
• we have no code review
• tests are missing (therefore NW)

It seems like the patches fixes the issue for some people. If they can reconfirm, or someone else can confirm as well, I will just commit the patch and open an issue for an explicit test as a task.

Also, fwiw, I just tested this myself, and with the patch the groups are indeed rendered.

So setting RTBC, will assign it to zuuperman first to get his opinion on it as well, but I feel like it's fine.

FWIW, +1 to #3 being RTBC. I've been using it for months without trouble. The rationale in #3 makes sense, the patch is extremely small. I don't know *that* much about the internals of IEF, but I've been bitten numerous times by the normal form workflows not doing what you expect, so instead of relying on #process callbacks, directly calling what we need makes sense to me.

Thanks,
-Derek

Tested and debugged. The patch is ok. The inline_entity_form_entity_form_alter is beïng called in the processing part of the form, so the #process is never executed.

The patch fixes it, but introduces the risk that someone else is also implementing the inline_entity_form_entity_form_alter hook. That module needs to come before fieldgroup.

Committed the patch and marking as fixed. Thx for the patch

Hello, since the rc2 update, this patch is no longer compatible and I got the same problem as before.
I had to rollback to the rc1 version.

@dcrespin : The committed code is still in, could you open a new issue with steps to reproduce?