"Add some fields to view" option is always empty

I *just* hit this myself.

A few notes:

Patch #4 applies against dev, not 1.2. (Should have read the patch filename to notice this)

Also, I'm not sure quite what's going on, but if I apply this patch, I can't get the "Add some fields to view" to work at all.

If I reverse the patch, then "Add some fields to view" works in some, but not all, of my views.

I still can't get it to work even with the patch. It still asks to "add some fields to view" does anyone have any update on this?
Thanks

I have a lot of fields. Actually if comment the hole 'if' in the patch I can get them available on the select box the problem is that even image fields are available which is something we shouldn't want and the autocomplete only finds one element.

Thanks anyway I was doing that already :). Unfortunately I don't have a lot of time to spare right now but as soon as I have any other info I'll post it

@carlitus @andreas-speck @trevorbradley
the patch doesn't work for me because the first element of the 'if' is $handler->field and not $handler->realField. Here's a patch that works for me.

Thanks. It works for me, seams like it takes care of all the cases now.

It works for me too.

@carlitus @andreas-speck maybe it's time for someone to mark this as fixed

It works for me too.

Thanks @Andreas Speck

#4 applied but not listed any data!

@na.karimi what patch have you aplied?

I could not apply #14 to the current v1.2 because line 44 already contains

if ($handler->field == $this->realField) {

I adjusted the patch accordingly.

There's far too much code duplication in the patch. Would be better to do something like:

if (in_array($this->realField, [
  $handler->field,
  $handler->field . '_value',
  $handler->realField . '_value',
])) {
  $field_options[$id] = $field_options_all[$id];
}

I implemented that, moved the section to its own method (as buildOptionsForm() is already too long), and removed some nesting.

Thanks for all who working on this patch.
I've stacked with this issue too.
The patch from #26 almost solved this issue.
But it didn't apply for latest version of module (8.1.2).
Moreover in patch from #26 was missed the "autocomplete_combine_results" option.
So I made own patch, and hope it solve this issue.

Sorry, I was wrong in my previous comment.
We don't have "autocomplete_combine_results" option in current branch.
It comes from another issue #3100867
So I removed this option from patch for this issue

My previous patch successfully applied on dev branch, but not for the current version 8.x-1.2
I added patch for this version (for the tag 8.x-1.2)

Cutting through some of the comments above, here's a helpful interdiff. As there's not much value introduced in #28, and given that it introduces many whitespace errors, let's ignore it. The exception is the following code, which should be fixed. So #26 is NW until this gets done (the other patches can be ignored as we need to fix this in HEAD):

+++ b/src/Plugin/views/filter/ViewsAutocompleteFiltersTrait.php
@@ -36,84 +36,105 @@ trait ViewsAutocompleteFiltersTrait {
+        '#title' => t('Minimum number of characters to start filter'),

Should be $this->t().

@aleevas: That's for catching it.

@colan thanks for your review.
I've uploaded a new one patch for HEAD .
I hope it will be usefull

It seems there could be a related issue and its patch ...

So added as related issue to be taken into account ...

put it back in "Needs work" to make sure about related issue

Please don't create deadlock by setting a collection of independent issues to NW.

Thanks everyone! There was still extra whitespace in #32 so I made the change from #30 in another commit.