I found that the module generates fatal errors because the directory name where GoogleDocs.php resides is low case "source" instead of "Source", as media API requires. So the module will work only in OS with case-insensitive directory names, like Windows. In Linux it fails.

The fix is simple: after I renamed the directory from "source" to "Source" in my Ubuntu the module works as expected.

CommentFileSizeAuthor
#6 media_entity_googledocs-source-plugin-exception-2985580-0.patch215 bytesvtamas
#4 2985580-directory-name-is-wrong.patch1.87 KBsocialnicheguru

Comments

calmforce created an issue. See original summary.

dakku’s picture

dakku commented
Status: Active » Needs review

Hi calmforce,
Thank you, I will review the patch and update.

socialnicheguru’s picture

socialnicheguru commented

I cannot create a patch to change the name of the directory

socialnicheguru’s picture

socialnicheguru commented
StatusFileSize
new 2985580-directory-name-is-wrong.patch1.87 KB

Because I could not create a patch to change the directory, I provided one to change the text in effected files to adhere to the current directory structure. This is just a temporary fix.

The correct one would be to change the case of the directory to match what is needed.

dakku’s picture

dakku commented

@SocialNicheGuru your patch seems to do the opposite of what @calmforce mentioned.
Can you please double check?

vtamas’s picture

vtamas commented
StatusFileSize
new media_entity_googledocs-source-plugin-exception-2985580-0.patch215 bytes

Attaching a patch for renaming the folder.

pookmish’s picture

pookmish commented
Status: Needs review » Reviewed & tested by the community

Thanks

rajab natshah’s picture

rajab natshah
he/him
commented

+1

  • vbouchet committed 4542f01 on 8.x-4.x authored by vtamas 
    Issue #2985580 by SocialNicheGuru, vtamas: The directory name for the...
vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Reviewed & tested by the community » Fixed

Thanks for you patch. I applied it and pushed to 8.x branch. I will soon create a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.