Problem :
In radix.info.yml file
regions:
navbar_branding: 'Navbar branding'
navbar_left: 'Navbar left'
navbar_right: 'Navbar right'
content: Content
footer: Footercontent and footer is not in proper format.
Solution :
As per the drupal.org guidelines , https://www.drupal.org/docs/8/theming-drupal-8/adding-regions-to-a-theme
content: 'Content'
footer: 'Footer'Both the above should be in single quote
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | regions_declared_is_not_proper-2985139-05.patch | 1.23 KB | morbus iff |
| #4 | regions_add.png | 37.41 KB | akash.addweb |
| #2 | regions_declared_is_not_proper-2985139-04.patch | 345 bytes | darshan.addweb |
Comments
Comment #2
darshan.addweb commented@Dinesh18, Please find the patch with your required changes & let me know if any further changes are required.
Comment #3
dinesh18 commentedLooks good to me. Let's wait for the maintainer to check & commit. Thanks
Comment #4
akash.addweb commented@ritika.addweb, Thanks for the patch, your patch works as per the expected standards. I checked and compared it with the standards mentioned in attached screenshot
Comment #5
morbus iffUpdating this to 4.x and including the kits' .info.yml.
Comment #6
jacineWhile, I agree it is nice to wrap them all in quotes for consistency, this page is not a "guideline". It is simply documentation. And this issue is not a bug report.
See all of the core themes that implement regions, they only quote the names that have more than one word:
- https://git.drupalcode.org/project/drupal/blob/8.8.x/core/themes/seven/s...
- https://git.drupalcode.org/project/drupal/blob/8.8.x/core/themes/bartik/...
Comment #7
ckngQuoting is not needed in YAML for these cases. It is not a standard to have quote here. Personally prefer no quotes.
See https://www.yaml.info/learn/quote.html
Comment #9
ckngThis was standardized as no quote in 4.x, doing the same here for 3.x.