Comments

byronveale created an issue. See original summary.

byronveale’s picture

Here's the patch.

byronveale’s picture

Okay, so the patch for link used in panopoly_core doesn't apply cleanly to link-7.x-1.5, testing without it.

byronveale’s picture

Status: Active » Needs review

We have a content type with link fields inside a field collection, with validation enabled, and no apparent issues, so going out on a limb and saying that the aforementioned patch is not needed…

dsnopek’s picture

Title: Upgrade Link to latest » Upgrade Link module to 1.5
dsnopek’s picture

dsnopek’s picture

Status: Needs review » Needs work

Tests pass, but we really need that patch! I tried the two most recent re-rolls of it, and neither worked, so I think we're gonna need to do our own re-roll.

dsnopek’s picture

Status: Needs work » Needs review
StatusFileSize
new675 bytes

Here's a new patch that adds the patch back to revert the validation logic in the 'link' module.

Here's a new Travis build: https://travis-ci.org/panopoly/panopoly/builds/484059305

  • dsnopek committed e5d1ba1 on 7.x-1.x
    Update Panopoly Core for Issue #2984994 by byronveale, dsnopek: Upgrade...
dsnopek’s picture

Status: Needs review » Fixed

Tests passed! Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.