Splitting this issue from #2982149: Routing: Convert system functional tests to phpunit since the outstanding task are harder then we tought.
So we can review this as smaller patch, and get this in core while we continue to work on the rest.

CommentFileSizeAuthor
#9 2984185-9.patch10.59 KBLendude
#4 2984185-4.patch10.52 KBscuba_fly
#2 2984185-2.patch10.22 KBscuba_fly
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scuba_fly created an issue. See original summary.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
CreditAttribution: scuba_fly at LimoenGroen commented
Status: Needs work » Needs review
FileSize
2984185-2.patch10.22 KB

And here is the patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2984185-2.patch, failed testing. View results

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
CreditAttribution: scuba_fly at LimoenGroen commented
Status: Needs work » Needs review
FileSize
2984185-4.patch10.52 KB

Rework of the patch, somehow my machine does not wants to create an interdiff.

Basically I just put the files in the right folder.

Status: Needs review » Needs work

The last submitted patch, 4: 2984185-4.patch, failed testing. View results

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
CreditAttribution: scuba_fly at LimoenGroen commented

Test fails locally:

PHPUnit 6.5.9 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\system\Functional\Page\DefaultMetatagsTest
Test 'Drupal\Tests\system\Functional\Page\DefaultMetatagsTest::testMetaTag' started
Test 'Drupal\Tests\system\Functional\Page\DefaultMetatagsTest::testMetaTag' ended


Time: 1.1 minutes, Memory: 6.00MB

There was 1 failure:

1) Drupal\Tests\system\Functional\Page\DefaultMetatagsTest::testMetaTag
Failed asserting that 0 matches expected 1.

/app/web/core/tests/Drupal/Tests/BrowserTestBase.php:1346
/app/web/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:57
/app/web/core/modules/system/tests/src/Page/DefaultMetatagsTest.php:21

FAILURES!
Tests: 1, Assertions: 3, Failures: 1.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Needs work » Needs review

Works fine locally for me, added a retest in Drupal CI, not sure why it was aborted.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
FileSize
2984185-9.patch10.59 KB

Moved test to the right dir. interdiff doesn't detect this as a change ....

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Assigned: scuba_fly » Unassigned

Both converted tests ran this time and passed. Conversion looks good to me.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

LGTM. Re-running test.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Parent issue: » #2982149: Routing: Convert system functional tests to phpunit

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2984185-9.patch, failed testing. View results

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Testbot hiccup.

The last submitted patch, 4: 2984185-4.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ae9e096498 to 8.7.x and d051a1dd5b to 8.6.x. Thanks!

  • alexpott committed ae9e096 on 8.7.x 
    Issue #2984185 by scuba_fly, Lendude:  Convert system functional tests...

  • alexpott committed d051a1d on 8.6.x 
    Issue #2984185 by scuba_fly, Lendude:  Convert system functional tests...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.