[D7] View and Style format list

Hi Revathi,

I have an suggestion to your module, Could please add links to your views and displays? So that, It would be easy for the developers to navigate to the respective views.

Hi Revathidinesh ,

I am just going to test your module on here https://pareview.sh/pareview/http-git.drupal.org-sandbox-revathidinesh-2... .. It's say 's "Git checkout of branch view_and_style_format_list failed. Aborting." ..

So please check module git url.
Thanks

The repository link is https://git.drupal.org/sandbox/Revathidinesh/2983230.git, and the PAReview link is https://pareview.sh/pareview/https-git.drupal.org-sandbox-revathidinesh-....

I fixed the links given in the OP.

To the reviewers: Please set the priority to Normal after reviewing the project.

Automated Review

Review of the 7.x-1.x branch (commit 37d4a7f):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) add views as dependency in view_and_format_list.info
2. (*) delete branch master-view-and-display-format-list
3. (+) use more descriptive commit messages from now on

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you used git@git.drupal.org:sandbox/Revathidinesh-2983230 as repository URL for Git commands, you need to use SSH keys for authenticating within Drupal.org Git.
It could be there are temporary problems with the server, since settings are being changed for the Gitlab migration.

Looks good, after a new installation, I found out, that it would be better to change the dependency to the Views UI module. Without it, the admin/structure/views menu is not visible.

I will approve the application this evening.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

You need to make a release from a Git tag. Development snapshots aren't shown with a green background, as far as I recall.

Perfect! It was just necessary to select it as recommended version in https://www.drupal.org/node/2983230/edit/releases. Now it has a green background.