Problem/Motivation

Date-only fields get indexed at midnight UTC. Core works around this issue by setting a 'default time' for date-only fields.

Proposed resolution

Add the default time before returning the timestamp in the DateDataType::getValue() method.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 2982660-02-TEST-ONLY.patch1.16 KBjhedstrom
#2 2982660-02.patch2.18 KBjhedstrom
#2 2982187-03-TEST-ONLY.patch5.3 KBjhedstrom

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new 2982187-03-TEST-ONLY.patch5.3 KB
new 2982660-02.patch2.18 KB
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Related issues: +#2945870: Datetime is indexed with system timezone (not storage timezone/UTC)

The last submitted patch, 2: 2982187-03-TEST-ONLY.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 2: 2982660-02.patch, failed testing. View results

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new 2982660-02-TEST-ONLY.patch1.16 KB

Not sure what that fail is about. However, this was the entirely wrong test-only patch. Here's the correct one.

The last submitted patch, 2: 2982660-02.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: 2982660-02-TEST-ONLY.patch, failed testing. View results

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review

That kernel test is failing on the main branch too (#2982693: Test failing on main branch).

In the meantime, this is back to NR.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Thanks for bringing this up. This is a really small bugfix and has test-coverage. Great work @jhedstrom!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Needs review

Seconded, awesome job, thanks! That you even provided tests without anyone nagging about it is just exemplary! ;)
Committed with a tiny bit of code clean-up.
Thanks again! (Also to Joris for reviewing!)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.