#2982210: Move EntityToJsonApi service to JSON API Extras landed in the 2.x version of JSON API which agreed to move the service into this module.

What's left?

Do it.

CommentFileSizeAuthor
#2 2982455-2.patch10.66 KBwim leers

Comments

gabesullice created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Related issues: +#2982210: Move EntityToJsonApi service to JSON API Extras
StatusFileSize
new 2982455-2.patch10.66 KB

You beat me to it :) Thanks for creating this issue!

Status: Needs review » Needs work

The last submitted patch, 2: 2982455-2.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yay! No failures!

(Well, 2 failures right now, but that's just because JSON API Extras HEAD is broken — being fixed in #2982133: No longer works with JSON API >=1.21 (so either 1.21 or 1.22).)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +API-First Initiative

This is just transplanting functionality from JSON API to JSON API Extras. If it was good enough there, it's good enough here.

+++ b/jsonapi_extras.services.yml
@@ -22,3 +22,7 @@ services:
+  jsonapi.entity.to_jsonapi:

Note that this even keeps the service name the same!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2982455-2.patch, failed testing. View results

  • e0ipso committed 56a01ce on 8.x-2.x authored by Wim Leers 
    Issue #2982455 by Wim Leers: Add `jsonapi.entity.to_jsonapi` service
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Fixed

Re-rolled, applied and committed. Thanks for the fix!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.