Migrate Drupal 7 taxonomy term entity translations data to Drupal 8

Queued for PostgreSQL and SQLite tests. I gave the patch a first quick round of eyeballs and it looks nice! I will test it and read it again possibly tomorrow.

Markus

+    $query = $this->select('entity_translation', 'et')
+      ->fields('et')
+      ->fields('td', [
+        'name',
+        'description',
+        'format',
+      ])
+      ->fields('tv', [
+        'machine_name',
+      ])
+      ->condition('et.entity_type', 'taxonomy_term')
+      ->condition('et.source', '', '<>')
+      ->distinct()
+      ->orderBy('tid');

This should be solved by adding tid to the "td" fields above.

I made quite extensive manual testing, inspecting the results in UI and in the database.

1. Bug: The publishing status is not mapped and thus D8 term translations are always 'published' even if the D7 translation is 'not published'.

2. Nit: Class description must start with a third person verb.

diff --git a/core/modules/taxonomy/src/Plugin/migrate/source/d7/TermEntityTranslation.php b/core/modules/taxonomy/src/Plugin/migrate/source/d7/TermEntityTranslation.php
new file mode 100644
index 0000000000..c417764339
--- /dev/null
+++ b/core/modules/taxonomy/src/Plugin/migrate/source/d7/TermEntityTranslation.php
@@ -0,0 +1,122 @@
+<?php
+
+namespace Drupal\taxonomy\Plugin\migrate\source\d7;
+
+use Drupal\migrate\Row;
+use Drupal\migrate_drupal\Plugin\migrate\source\d7\FieldableEntity;
+
+/**
+ * Taxonomy term entity translation source from database.

3. Nit: I think we used uppercase ID in other entity translation source plugins

+  public function fields() {
+    return [
+      'entity_id' => $this->t('The entity id this translation relates to'),
+      'revision_id' => $this->t('The entity revision id this translation relates to'),
+    ];
+  }

4. Test coverage MigrateTaxonomyTermTest.php
Could we please have test coverage for other metadata properties as well?

Cheers,
Markus

That was super fast response @maxocub!

I reviewed #14. All feedback is addressed so this is RTBC once the tests (that are currently running) are green.

My evening practice is starting soon so it would be good if somebody can switch the status after the tests have finished so that we can get this to Gabor's final review queue ASAP during our mini-sprint week.

Thanks once more @maxocub!

Cheers,
Markus

The tests turned out to be green as expected, RTBC.

I think this looks great. I got blocked to commit this by my local dev environment blown away with the Mac Mojave upgrade. If another committer gets to this sooner, please commit :)

Committed/pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!