Wrong message on cancelling account with e-mail confirmation request

This still applies to Drupal 8.

Attached is an attempt at the start of a patch. This still needs tests.

Drupal 8.9.x is in security support only.

Applied patch
after patch user is able to cancel account with-out any email verification message for ref sharing screenshot

#3199972: Improve user interface text on the account cancellation screen was just committed, which should help get this moving along.

Verified and tested patch #5.
Patch applied successfully and there is no difference.

Testing Steps:
# Goto: Appearance -> Apply Seven theme
# Goto: /admin/people
# Edit any user
# Click the 'cancel account' link for any user (other than yourself)
# Check the 'Require e-mail confirmation to cancel account' option
# Click the 'cancel account' button

Expected Results:
# User should see messages like "A confirmation request to cancel this user account has been sent to the user’s e-mail address"

Note: I don't see any difference before and after applying the patch. The same message is appearing.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

We will be discussing this issue at #3244123: Drupal Usability Meeting 2021-10-22 so moving back to NR for now.

We reviewed this issue today at #3244123: Drupal Usability Meeting 2021-10-22.

The recommendation was to change the message slightly for canceling the account of another user to add the name of the user instead of the text "the account".

So instead of:

A confirmation request to cancel the account has been sent to the user's email address.

It would be:

A confirmation request to cancel %name% has been sent to the user's email address.

This issue summary also needs an update as it looks like it comes from Drupal 7.

As a side note I think some of the other changes in the patch are out of scope, mainly:

+    $current_user = $this->currentUser();
+    $is_canceling_own_account = ($this->entity->id() == $current_user->id());
+
     // Cancel account immediately, if the current user has administrative
     // privileges, no confirmation mail shall be sent, and the user does not
     // attempt to cancel the own account.
-    if (!$form_state->isValueEmpty('access') && $form_state->isValueEmpty('user_cancel_confirm') && $this->entity->id() != $this->currentUser()->id()) {
+    if (!$form_state->isValueEmpty('access') && $form_state->isValueEmpty('user_cancel_confirm') && !$is_canceling_own_account) {
       user_cancel($form_state->getValues(), $this->entity->id(), $form_state->getValue('user_cancel_method'));

This is still NW as per #13. I'm not sure about the suggested wording though. For example:

A confirmation request to cancel mstrelan has been sent to the user's email address.

I don't want to be cancelled!

A confirmation request to cancel mstrelan has been sent to the user's email address.

I don't want to be cancelled!

Yeah I wouldn't want to be cancelled either so maybe we need to revisit this 😀

re-rolling patch for 10.1.x

I had Reviewed the patch and it looks good and working as expected mentioned in comment #19

Issue needs to go back to usability group for another review, setting back to NR.

I have applied the patch #19. I think it's just a re-roll. It doesn't make any changes on message as per comment #13.

Adding a patch addressing the points mentioned in #13, removing out of scope code and updated message wording as per #17 so it doesn't sound weird. Please review.

Fixed CCF on #23

Updated the patch with test case changes.

Updated the testing scenario fixes.

Seems the fail is random. Keeping to Review.

+      else {
+        $messenger->addStatus($this->t("A confirmation request to cancel %name account has been sent to the user's email address.", ['%name' => $this->entity->label()]));
+      }

It should be to cancel the %name account, in the same way it is to the user's email address.

#35 comment has been addressed with the latest Patch.

#13 tagged this for issue summary update from the usability meeting at that time. Still needs to happen it seems.

Usability review

We discussed this issue at #3377568: Drupal Usability Meeting 2023-08-04. That issue will have a link to a recording of the meeting.

For the record, the attendees at today's usability meeting were @AaronMcHale, @Emma Horrell, @benjifisher, @rkoller, @simohell, and @worldlinemine.

We reviewed this in the context of the recent discussion. In comment #13 we recommended the following:

A confirmation request to cancel %name% has been sent to the user's email address.

However, it was pointed out that this wording could imply that the person themselves is being cancelled, and to quote @mstrelan in comment #17:

A confirmation request to cancel mstrelan has been sent to the user's email address.

I don't want to be cancelled!

With that in mind, we are now recommending the following wording, which should address the concern and is a slightly variation on the previous recommendation, adding the text "the account":

A confirmation request to cancel the account %name has been sent to the user's email address.

We considered a slightly shorter version, without the text "to the user's email address", however while we normally follow the less-is-more principle, we felt it was better to be explicit that the request is indeed being sent to the user's email address.

We also considered a couple of other variations on account %name, including: account (%name) and %name account, but we felt these were a bit awkward when reading the complete sentence.

I should also note that if #3229146: Rename "Account cancellation" to "Account closure" in UI is done, then this wording will change again slightly, replacing the word "cancel" with the word "close".

Also cleaning up the issue summary as it's a bit out of date now.

Updated previous comment to note other variations on account %name that were considered. I think this still needs an IS update, so leaving that tag.

The issue summary is clear and up to date. So removing the tag
I have changed the message to A confirmation request to cancel the account %name has been sent to the user's email address as suggested in #40.
. Raising it as a merge request.

Hi @Akhil Babu, I've Tested the shared MR-MR !6303 mergeable on Drupal Version- 11.0-dev, The Patch was applied successfully and looks good to me.

Testing Steps:

1. Install Drupal-11.
2. Go to> admin/people- Create a new user.
3. Edit the user & Click on the Cancel Account and Check the 'Require email confirmation' check box. Attached before results.
4. Download the shared patch & apply.
5. Go to> admin/people- Edit the user & follow the above steps to re-verify this.

Testing Results:
After applying the patch, the confirmation message has been changed. RTBC++

I think the code here is currently not working the way we expect it to, i.e. the condition is always false and therefore the case where the user is cancelling their account is showing the wrong message.

This likely means some of the test changes were not correct

I can confirm that this does need work. The confirmation message is now incorrect when a user cancels their own email address:

A confirmation request to cancel the account example_user has been sent to the user's email address.

Can the issue summary be flushed out some please

Always recommend to never remove summary heading, even if they don't apply just leave blank or put NA.

Put proposed solution can it be more specific, don't need code but looking at the changes seems to be doing more then just altering the message.

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Updated the issue summary.

Believe feedback on this one has been addressed
Hiding patches since the fix is in the MR

small code improvement needed

I applied the suggestion and rebased the MR too.

Feedback appears to be addressed.

Committed 4760161 and pushed to 11.x. Thanks!