When looking at the XHProf result table, the first column that normally shows the name of the function is not being shown.

Inspecting this table in the browser shows the following CSS hiding this first column:

@media only screen and (max-width: 1800px)
table.responsive th:first-child, table.responsive td:first-child, table.responsive td:first-child, table.responsive.pinned td {
display: none;
}

Not sure why this is being done. But in debugging this I notice that the xhprof.css file is changing the styling of ALL responsive tables on the site. This needs to be rewritten to only affect the XHProf result table. You need to add a css class to this table output so you can use it to restrict the css changes.

CommentFileSizeAuthor
#3 xhprof-over-responsive-2980756-3.patch394 bytesmikeryan

Comments

mpotter created an issue. See original summary.

andypost’s picture

Yep, it looks ugly sometimes, https://cgit.drupalcode.org/XHProf/tree/css/xhprof.css#n101

For sure global styling should be removed

mikeryan’s picture

Status: Active » Needs review
StatusFileSize
new394 bytes

Quick and dirty fix - I'm not sure I see where hiding the function name column (the very most important one!) is helpful in any responsive situation.

andypost’s picture

Assigned: Unassigned » lussoluca
Status: Needs review » Reviewed & tested by the community

++ IMO better to remove this styles

moshe weitzman’s picture

Status: Reviewed & tested by the community » Fixed

I'm not really maintaining this module but I needed it today so trying to pitch in. This patch works and is sorely needed so in it goes.

  • moshe weitzman committed decf448 on 8.x-1.x
    Revert "Issue #2980756 by mikeryan: Global table CSS being overridden...
moshe weitzman’s picture

Status: Fixed » Needs work

Sorry, had to revert this. I was seeing the Function name column being duplicated and offset a bit in the new symbol detail page.

andypost’s picture

Assigned: lussoluca » Unassigned