Problem/Motivation

Unchecked checkboxes are displayed in preview and email with the label and 'No' displayed. This is not always the expected behavior.

Proposed resolution

Add 'exclude unselected checkboxes' from email notification and preview.

Remaining tasks

  • Update webform entity settings
  • Update webform preview form
  • Add #exclude_empty support to checkbox element
  • Update webform email handler
  • Update webform submission view builder
  • Update exported config
  • Write tests
  • Write change record

User interface changes

New configuration setting

API changes

None

Data model changes

None

CommentFileSizeAuthor
#19 2977378-19.patch158.76 KBjrockowitz
#16 2977378-16.patch145.68 KBjrockowitz
#14 2977378-14.patch141.89 KBjrockowitz
#11 2977378-11.patch138.81 KBjrockowitz
#7 2977378-7.patch398.18 KBjrockowitz
#3 2977378-3.patch7.16 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

  • jrockowitz committed 90c2a1a on 2977378-exclude-unselected-checkboxes 
    Issue #2977378: Add 'exclude unselected checkboxes' from email...
jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 2977378-3.patch7.16 KB
jrockowitz’s picture

jrockowitz commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 3: 2977378-3.patch, failed testing. View results

  • jrockowitz committed de4ec52 on 2977378-exclude-unselected-checkboxes 
    Issue #2977378: Add 'exclude unselected checkboxes' from email...
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 2977378-7.patch398.18 KB
jrockowitz’s picture

jrockowitz commented
Related issues: +#2944098: Option to hide unchecked checkboxes from submission values

Status: Needs review » Needs work

The last submitted patch, 7: 2977378-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • jrockowitz committed 187f606 on 2977378-exclude-unselected-checkboxes 
    Issue #2977378: Add 'exclude unselected checkboxes' from email...
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 2977378-11.patch138.81 KB
jrockowitz’s picture

jrockowitz commented
Issue summary: View changes

  • jrockowitz committed 2564c99 on 2977378-exclude-unselected-checkboxes 
    Issue #2977378 by jrockowitz: Add 'exclude unselected checkboxes' from...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 2977378-14.patch141.89 KB

  • jrockowitz committed e39aa27 on 2977378-exclude-unselected-checkboxes 
    Issue #2977378 by jrockowitz: Add 'exclude unselected checkboxes' from...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 2977378-16.patch145.68 KB
jrockowitz’s picture

jrockowitz commented

The last test that needs to be updated is \Drupal\webform\Tests\Handler\WebformHandlerEmailAdvancedTest

  • jrockowitz committed b3414d2 on 2977378-exclude-unselected-checkboxes 
    Issue #2977378 by jrockowitz: Add 'exclude unselected checkboxes' from...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 2977378-19.patch158.76 KB
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • jrockowitz committed c672188 on 8.x-5.x 
    Issue #2977378 by jrockowitz: Add 'exclude unselected checkboxes' from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.