Closed (fixed)
Project:
Electra
Version:
8.x-1.0
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 May 2018 at 05:34 UTC
Updated:
29 May 2018 at 16:27 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
bandanasharma commentedComment #3
brahmjeet789 commentedComment #4
rahulrasgon commentedHere is the patch and screenshot too. Need Reviews.
Comment #5
brahmjeet789 commented@rahulrasgon your last patch causes error ,please refer to screenshot.
Comment #6
rahulrasgon commentedSorry Guys, got some testing code in local machine, that's why that patch was not applying. Here is the updated patch. Working fine for me. Needs Review.
Comment #7
rahulrasgon commentedComment #8
brahmjeet789 commentedI am facing these type of errors while applying your patch.
Comment #9
rahulrasgon commentedHello Brahmjeet789,
I just cross check the patch and working fine for me. Kindly make sure you are applying the patch in right way as mentioned here Git Instructions.
I have attached the screenshot of steps followed by me. And let me know if others are facing the same issues.
Comment #10
bandanasharma commented#6 patch is apply successfully. It's working fine on Chrome and Firefox. attached the screen shot.
But some coding standard issues find in the scss file such as:
1. No new line in the end of the file
2. No one space after colon in the property.
Comment #11
bandanasharma commentedMake these changes and upload the patch.
Comment #12
bandanasharma commentedComment #13
brahmjeet789 commented@bandana: your patch is applied successfully and i can see the changes in the comment so i am moving this issue to RTBC.
Comment #14
brahmjeet789 commentedComment #15
sreenivas bttv commentedComment #16
sreenivas bttv commented@bandanasharma patch electra-updated_comment_fix_ui_on_restricted_html-2975212-11.patch is not the right solution. It works only for comment form. So need to fix towards textarea element if available in any form.
Comment #18
sreenivas bttv commentedCommitted and pushed to 8.x-1.x branch
Comment #19
sreenivas bttv commentedComment #20
sreenivas bttv commentedComment #21
sreenivas bttv commented