Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Returns empty key in views data for entities w/o revisions with described list builder.
Empty key contains 'operations' data.
Comments
Comment #2
davps CreditAttribution: davps as a volunteer and at DrupalJedi commentedComment #3
tstoecklerYes, this is a clear oversight. Patch looks perfect. We need some tests for this, though. That shouldn't be too hard, though, we already have
EntityViewsDataTest::testGetViewsDataWithEntityOperations()
for example, so I think we can either expand that or add a new similar method.Comment #6
efpapado CreditAttribution: efpapado at Ramsalt Lab commentedWould something like this be considered enough as a test?
Comment #7
efpapado CreditAttribution: efpapado at Ramsalt Lab commentedSet to "needs review" and remove tag "needs tests"
Comment #8
efpapado CreditAttribution: efpapado at Ramsalt Lab commentedActually this should be the correct one, if the test is acceptable.
Comment #9
tstoecklerThanks @efpapado, the test looks great. To prove that it does what it says, can you upload a patch with just the test? That should then fail. That would be great.
Comment #10
efpapado CreditAttribution: efpapado at Ramsalt Lab commentedOK
Comment #11
davps CreditAttribution: davps as a volunteer and at DrupalJedi commented@efpapado Test #10 doesn't cover described case, because the entity used in test is revisionable. Test #10 passes for all entities with/without revisions.
Let's try this test and patch.
Comment #13
efpapado CreditAttribution: efpapado at Ramsalt Lab commentedVery nice! I think I can set it to RTBC now :)
Comment #16
tstoecklerTestbot is retesting the wrong patch, so here's a re-upload.
Comment #18
larowlanCommitted 3a87d23 and pushed to 8.8.x. Thanks!
C/p to 8.7.x