Closed (outdated)
Project:
Display Suite
Version:
8.x-3.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 May 2018 at 08:37 UTC
Updated:
16 Aug 2019 at 07:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nkoporecCreated a patch.
Comment #3
useernamee commentedPatch applies and all calls to
drupal_set_message()are changed with the messanger service.Comment #5
aspilicious commentedTests are failing because you changed the constructor of "FieldFormBase" but you didn't adjust the other implementations.
In fact I'm reluctant to commit this because of that change, as it will break all custom implementations that extend our base class. And I know there are some.
Could you maybe not inject the messenger service for this class and just fetch the service with the Drupal::service helper function?
Comment #6
vdenis commentedAttached the updated patch. Please review it.
Comment #7
vdenis commentedTests passed so marking this as "needs review".
Comment #8
swentel commenteddrupal_set_message was removed in a different patch.