Muted attribute not working for Video file

Reroll of patch #2 for formatting so that it applies cleanly with composer-patches.

Rerolled

This should be fine

In order to commit a bug fix we need an automated to test to prove that we've fixed the bug and ensure that we don't break it again in the future. For more information about writing tests in Drupal 8 see the following links:

1. https://www.drupal.org/docs/8/testing
2. https://api.drupal.org/api/drupal/core%21core.api.php/group/testing/8.7.x

I can confirm, that #12 fixes the issue. Drupal 8.6.2.

Patch in #12 works for 8.6.3

first crack at the tests.

confirmed it failed before the fix in #12 and works after patch is applied

@thejacer87 thanks for working on the tests. One thing we do is upload a test-only patch along with the fix patch - that way you can prove to the community the new tests fail as expected.

1. +++ b/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php
   @@ -64,7 +64,15 @@ protected function createMediaField($formatter, $file_extensions, array $formatt
   -    $display = entity_get_display('entity_test', 'entity_test', 'full');
   +    $values = [
   +      'targetEntityType' => $entity_type,
   +      'bundle' => 'entity_test',
   +      'mode' => 'full',
   +      'status' => TRUE,
   +    ];
   +    $display = \Drupal::entityTypeManager()
   +      ->getStorage('entity_view_display')
   +      ->create($values);
   

   Why are these changes necessary?

2. +++ b/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php
   @@ -89,4 +97,18 @@ public function dataProvider() {
   +  /**
   +   * Data provider for testAttributes.
   +   *
   +   * @return array
   +   *   An array of data arrays.
   +   *   The data array contains:
   +   *     - An array of settings for the field formatter.
   +   */
   +  public function attributesProvider() {
   

   The provider should probably be in FileVideoFormatterTest. Also using a provider when there is only one test seems unnecessary - or is there a need to expand this?

@alexpott

1. i noticed that `entity_get_display` was deprecated, so i figured i would just take care of it now

2. no rhyme or reason, just copying the same pattern the other test does. but i see now the dataProvider in the testbase is used by both audio and video

ill fix it up and repost an updated failing patch and working patch

here's just the test

and the full patch

The test looks great.

+++ b/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php
@@ -64,7 +64,15 @@ protected function createMediaField($formatter, $file_extensions, array $formatt
-    $display = entity_get_display('entity_test', 'entity_test', 'full');
+    $values = [
+      'targetEntityType' => $entity_type,
+      'bundle' => 'entity_test',
+      'mode' => 'full',
+      'status' => TRUE,
+    ];
+    $display = \Drupal::entityTypeManager()
+      ->getStorage('entity_view_display')
+      ->create($values);

Whilst technically correct this change is still out-of-scope. Replacing all the usages of the deprecated entity_get_display() needs to be done a separate issue.

heres the patch without the deprecation fix

#27 applies cleanly on 8.6.7 and resolves the issue.

For when will this patch enter the core?
Version 8.6.13 and same problem

Thanks !!

Issue is still present in 8.7.0

#27 applies cleanly and fixes the issue.

Applied patch #27 to 8.8.x-dev, looks good

Committed cbb7ef0 and pushed to 8.8.x. Thanks!

Will backport to 8.7.x once the branch is out of commit freeze.

diff --git a/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php b/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php
index 2727e6911d..1b9982d551 100644
--- a/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php
+++ b/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php
@@ -55,7 +55,6 @@ public function testRender($tag_count, $formatter_settings) {
     $assert_session->elementExists('css', "video > source[src='$file2_url'][type='video/mp4']");
   }
 
-
   /**
    * Tests that the attributes added to the formatter are applied on render.
    */
@@ -94,7 +93,6 @@ public function testAttributes() {
     $assert_session->elementExists('css', "video[autoplay='autoplay'] > source[src='$file_url'][type='video/mp4']");
     $assert_session->elementExists('css', "video[loop='loop'] > source[src='$file_url'][type='video/mp4']");
     $assert_session->elementExists('css', "video[muted='muted'] > source[src='$file_url'][type='video/mp4']");
-
   }
 
 }

diff --git a/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php b/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php
index 1b9982d551..8517b3244d 100644
--- a/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php
+++ b/core/modules/file/tests/src/Functional/Formatter/FileVideoFormatterTest.php
@@ -65,7 +65,7 @@ public function testAttributes() {
       [
         'autoplay' => TRUE,
         'loop' => TRUE,
-        'muted' => TRUE
+        'muted' => TRUE,
       ]
     );
 

Fixed a couple of coding standards.

This is still a problem in 8.9.7 Was this included in core?

This automagically started working after two days.