Much like #2966363: CommentTest::testPatchIndividual() failing on 8.6 broke due to access control handler changes in core in 8.6 in #2950125: Add helpful reason for 'update' and 'delete' access not being allowed to CommentAccessControlHandler, the same happened again in #2950129: Add helpful reason for 'update' and 'delete' access not being allowed to MediaAccessControlHandler.

This can also be seen in daily branch tests against 8.6:

CommentFileSizeAuthor
#4 2969493-4.patch1.15 KBwim leers
#4 interdiff.txt899 byteswim leers
#2 2969493-2.patch836 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2969493-2.patch836 bytes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: MediaTest::testPatchIndividual() failing on 8.6 » MediaTest::testPatchIndividual() and MediaTest::testDeleteIndividual() failing on 8.6
StatusFileSize
new interdiff.txt899 bytes
new 2969493-4.patch1.15 KB

Passed on 8.5, failed on 8.6. Because I only updated PATCH, I should also have updated DELETE 🙈 So #2 only solved half the problem.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task

Also, this isn't a bug; it's a task: staying in sync with upstream changes in core's next minor.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Both are green!

  • Wim Leers committed eb29dd0 on 8.x-1.x 
    Issue #2969493 by Wim Leers: MediaTest::testPatchIndividual() and...
  • Wim Leers committed 53127cb on 8.x-2.x
    Issue #2969493 by Wim Leers: MediaTest::testPatchIndividual() and...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.