The emails can be more granular to content type level.

Scenario

I have 2 content types. I have 2 entirely different email contents and rules for that 2 content types. Currently, its not configurable.

CommentFileSizeAuthor
#23 2965600-content-type_23.patch8.41 KBmamoruua
#20 2965600-content-type_20.patch8.97 KBerik_petra
#11 2965600-content-type_11.patch9.41 KBdhirendra.mishra
#11 interdiff_6-11.patch1021 bytesdhirendra.mishra
#6 2965600-content-type_6.patch9.37 KBanish.a
#2 2965600-content-type.patch9.37 KBanish.a

Comments

anish.a created an issue. See original summary.

anish.a’s picture

anish.a commented
Status: Active » Needs work
StatusFileSize
new 2965600-content-type.patch9.37 KB

The initial patch. Needs work to generalize it. No tests has been added.

No upgrade path also is there.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Would it make more sense to utilize different workflows for the different content types? Then this module can simply be set to use the different workflows available...

pameeela’s picture

pameeela commented

Thanks @jhedstrom for the suggestion, a different workflow will work for me, although the actual workflow is the same...

I was a little confused because the screenshots on the module page show options to select the bundle. So was this supported at one point and then removed? Updating the screenshots would be helpful to avoid confusion, I think.

letrollpoilu’s picture

letrollpoilu commented

I'm so sad to see that now after seeing the module screenshot...

I'm exactly in the same case, moreover Rules and Workbench Emails are not working for me. This module works well but since I have the same Workflow for all my content but I need different emails sent to different roles depending on Content Type, this module becomes useless to me...

I tried to apply the patch on the current dev version but this is not working... Is there anything that can be done? I'm afraid I'll have to program my notification manually then. Anyway thanks for this module.

anish.a’s picture

anish.a commented
StatusFileSize
new 2965600-content-type_6.patch9.37 KB

@letrollpoilu

I rerolled the patch for latest version. Try it out. I am not sure if its working.

If the maintainer is ok to make this feature available on the module, I can work on the patch to include tests, porting for latest dev, upgrade path, etc.

letrollpoilu’s picture

letrollpoilu commented

Thanks a lot for your quickness! I will test the patch in the next days and will come back to you.

letrollpoilu’s picture

letrollpoilu commented

I don't really know what happened. I tested it when I had only one content type set up with the moderation process and this was working fine. Now that I developed all the forms, I have like 7 content types and the module is not working anymore, not sending any notification... So I removed the patch and reverted to the 3.3 version but it is still not working.

SO I don't know if there is a bug in my config or if the patch made that. In any case, the module is not working for me anymore... I don't really know what to do so I'm thinking of trying to implement my notifications with Rules.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs work » Needs review

NR for #6

Status: Needs review » Needs work

The last submitted patch, 6: 2965600-content-type_6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dhirendra.mishra’s picture

dhirendra.mishra commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_6-11.patch1021 bytes
new 2965600-content-type_11.patch9.41 KB

Status: Needs review » Needs work

The last submitted patch, 11: 2965600-content-type_11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alzz’s picture

alzz commented

Tested #11 patch and is working ok! only sends email for the selected content types.

letrollpoilu’s picture

letrollpoilu commented

Actually, I could also make everything work properly. Seems like the patch is working!

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented

Some tests are failing. Those tests should be examined and their functionality cheched, then either fix the tests or fix the functionality.

smustgrave’s picture

smustgrave commented

Could I make a suggestion but since a workflow can be attached to media and blocks also should this patch be expanded to cover those also vs just content types?

anish.a’s picture

anish.a commented

As original author of the patch, it was a quick and dirty solution for that specific problem. I was not sure whether its a correct solution, or even if it will be used by many people to be included in the module. I uploaded the patch as is.

If there is many interest for this feature and maintainer is ok to merge, I can work on it to polish the code and include tests and migration path.

smustgrave’s picture

smustgrave commented

Can try and take a look more later but in ContentModerationNotificationsFormBase it loads the workflow to grab the transitions. If the workflow is loaded it can then grab the entity types (media, blocks, node, etc) the workflow is attached to.

Is with loading all the content types is you could be setting up a a notification for a content type that doesn't have workflow.

anish.a’s picture

anish.a commented
Assigned: anish.a » Unassigned
erik_petra’s picture

erik_petra commented
StatusFileSize
new 2965600-content-type_20.patch8.97 KB

Re-roll of the patch that works for version 3.7.0

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs work » Closed (won't fix)

I see Content Moderation Notifications as serving a simpler use case. This patch adds some complexity, and it also assumes that the workflow entity is a node, which is not always the case. For these more advanced use cases, I think the ECA module would be a better fit. Please feel free to re-open if anyone disagrees here. I recently became a co-maintainer and I'm trying to clean up the issue queue and keep the module streamlines to make it more maintainable.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

mamoruua’s picture

mamoruua commented
StatusFileSize
new 2965600-content-type_23.patch8.41 KB

Re-roll of the patch that works for version 3.8.0