Total Views Counter is not updated

There is a step missing. The content must be viewed in order to increase the count. I've tested that after viewing the full content that the number increases.

Did you try clearing cache after viewing the node? I think the statistics are cached for one hour; I saw something about that. Is the count getting updated in the database? Also, try viewing the node as a non-admin one time; That's what I did anyway.

Are you viewing the rendered view or from the admin screen?

It is easy to reproduce. The problem is that a cache is not invalidated. Check the caching settings on the view. If it is "tag-based", the displayed value will not change even though the stored value is incrementing properly.

There is a missing cache tag somewhere because this counter does not increment when a view is cached as tag-based.

So, when the content is viewed, the statistics cache needs to invalidate? I guess I don't understand cache tags enough right now to fix this.

I'll try to write the test case. This could be the wrong place to put the test.

This patch is just to see if viewing the node in this test actually affects the existing test.

This test passed. So, this is just making a point that the code eliminated in this patch is not actually working as expected.

and/or applying the patch seems to work

There is no patch yet. The patch in this issue is just the test case. So, setting to Active.

In my case this happen because I was using panelize module.

This is still an issue. I can confirm clearing cache works, but I do not want to clear cache too often so the site would became slower. Is there anything we can do about it? I turned off caching for views block but it does nothing.

lubwn i have faced the same issue.Even if you turn off views block cache it won't show. After disabling entire page cache it shows correctly.i am still checking another possible ways like without disabling entire page cache to show node views count correctly.

@drupal-ramesh, have you got any solutions for it. I'm also facing same issue, node view count is not getting updated on the page load. we need to clear the cache for it.

Hi sarguna raj M

Need to add a new cache tag that has to invalid when the view count changed. Each Views having node_list cache tag that is only invalid when node value changed(not on view count change).

I can't figure it out. But somewhere (NodeViewController?) the view needs to be invalidated. Still need a new cache tag for statistics; Don't know where that goes. Posting for discussion.

The test in #11 needs a reroll.

Hi

I added new patch to invalidate the node_list cache tag. I invalidated that node_list cache tag when node_counter table updated.

Hi @KapilV , patch #34 applied cleanly but not working as expected counter not increasing, sharing screenshot for reference.

Hi

In each view i am getting node:node_id(node:1) cache tag. node_list cache tag added for all views. So invalidate node_list cache tag it will affect all views . so instead of node_list cache tag i invalidated node:node_id cache tag. So without clear cache node counts shows correctly in both node and view page.

Fixing fail test, Have a look and advise.

#38 is just a hard work-around with far-reaching consequences.

The real bug lies in \Drupal\statistics\Plugin\views\field\StatisticsNumeric — it does not provide cacheability metadata whereas it should. You need something like the attached patch. It can use further refinement, especially configurability.

Related: \Drupal\views\Plugin\views\field\UncacheableFieldHandlerTrait, introduced by #2450897: Cache Field views row output.

For me the counter was stuck at zero, but it was ublock origin blocking that feature.

I tried testing #39, but I found another issue.
I have 2 basic pages in my view. both have an equal no. of views every time. if I open only one page. No. of views increases for both the pages.

Attaching screen recording for same.

Hi Community Members,
I have tested this issue and working as expected for me.

Testing Steps:
# Goto: Appearance -> Apply Seven Theme
# Enable Statistics module.
# Make sure that under /admin/config/system/statistics "Count content views" is enabled.
# Create a basic node view, add a "Content statistics: Total views" field to the view. The field display is always 0 no matter what

Expected Results:
# User should see the nodes value correctly whenever the user opens the respective node like 2 times, 3 times

Please refer attached screenshots and Video for the same.
Looks good to me.
Can be a move to +1 Needs Review.

Applied patch #39 successfully applied
After patch we can able to see count of nodes after visit node
For ref sharing screenshot ....
Thanks for the patch

After 2 more years I am again stumbling upon this problem. Still not solved, making statistics module obsolete.

Patch #39 does nothing on my installation.

I found a workaround:

1. Create field "Number of views" being Number (integer)
2. Write your own module to increment number on each page hit
3. Add your newly added field to views or wherever you wish

I am supplying the code I have used:

function YOUR_MODULE_node_view(array &$build, EntityInterface $entity, EntityViewDisplayInterface $display, $view_mode) {
	
	if ($entity->bundle() == 'article') {
		
		$number_of_views = $entity->get('field_number_of_views')->getString();
		
		if (empty($number_of_views)) {
			$number_of_views = 0;
		}
		
		$number_of_views++;
		
		$entity->set('field_number_of_views', $number_of_views);
		
		$entity->save();
		
	}
	
}

This works fine for me even with caching enabled. It is sad that Drupal got so absurdly complicated that such a minor issue takes years to solve and is not solved at all...

@lubwn Constructive comments and manual testing results as you have made here are welcome contributions. But complaining accomplishes nothing. Participate if you wish to have influence over the product.

Hi everyone,

I found an easy way to fix this problem. The statistics module already has a 'display_max_age' setting for the counter, so I added it to the settings form using a patch. After that I set it to 0 and saved it. Clearing the entire cache is not optimal, but it is very easy to optimize for Drupal-ninja (as I think :)). I don't have time for this right now, sorry.

Best regards, Andrew

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

Tested on Drupal 10.1.x following the same steps in the IS but was not able to replicate.

Are there additional steps?

I also tested this on Drupal 10.1.x and I was able to reproduce the problem. That is, I had to clear cache for the counts to update.

Statistics is approved for removal. See #3266457: [Policy] Deprecate Statistics module in D10 and move to contrib in D11

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

It will be moved to a contributed Statistics project once the project is created and the Drupal 11 branch is open.

@quietone I am experiencing the same.

View cache and page cache is set to not-set for time-based caching.

Tried changing to tag based and seems to be the same.

display_max_age: 0
count_content_views: 1

Admin view does seem to show correct value.

@cilefen Your explanation sounds correct.

@Andrew Answer I tried the same locally i.e. setting max-age to 0 but the result is the same.

@drupal_ramesh Thank you!

From what I can see this invalidates the node tag cache using the node id that the stat is generated right after the storage is updated.

@Wim Leers please can you explain what your patch does and how to use it? Can you also elaborate what the far reaching consequences are of ramesh's solution here?

Changing to 10.2 as this appears to be a bug and statistics is scheduled to be moved to contrib in 11.x

Ok I have rerolled previous patch. This contains both elements of #38 (working) and #39 (not working)

drupal_issues_2962763_test2.patch works for me locally.

I have not included the test as my assumption here is we probably need a new test for this, rather than changing the previous one. Not sure.

Counts are updating for now. This is without actually changing page cache (under performance) and the default views max-age cache on the view. Changing the cache to cache tags on the view seems to make little difference.

Browser still needs reloading to show the view count so I guess edge cache is still in place here, again not really sure.

Converted #59 latest patch by @2dareis2do to MR!7 https://git.drupalcode.org/project/statistics/-/commit/c00a33433c3a243d6...

@2dareis2do 's answer on Slack :

My patch is just a collection of other peoples commits so I am not sure I am the best qualified person to review this. This patch has been working for me though. In the meantime I have decided to restrict stats view to registered users as as well.

Looks like there are quite a few change in statistics module. with 10.3 release.

https://github.com/drupal/drupal/tree/10.3.1/core/modules/statistics

Patch does not apply and statistics are not updating.

Patch probably needs to be re rolled.

Updated for 10.3

Note that this issue is about the contrib statistics project, not statistics in core, but the link you mention https://github.com/drupal/drupal/tree/10.3.1/core/modules/statistics is about core.

Right sorry. my bad.

Am i right in thinking this started as a core issue?

To clarify, patch is for core module not contrib (as per the previous one).

I guess the issue will never be fixed in core if the issue queue is now in contrib.

You're 100% right. Even more so now that 11.0.0 has been released and no longer contains statistics.

Updating issue to current Statistics release.

The module worked fine till I started using it as a contrib module (after it was moved out of core).

Now, the counter does not move. No matter what.

If the counter doesn't move, then this module is of no use really.

@newswatch you will need to provide more details about your configuration, possibly a a URL, to receive help. Without that we cannot know what does not work on your site.

First, can you reproduce the problem on a new site with just D11 core and statistics ?

@fgm: MR LGTM, what's the further plan here?

@anybody : awaiting a return from @newswatch since they appear to say it doesn't work for them, but I do not see how that can happen so we need more info.

@fgm thanks! So if I get you right, you assume the MR maybe isn't needed?

Anyway I'd like to propose that lazy builders *might* be a nice solution for this case!
https://www.hashbangcode.com/article/drupal-9-using-lazy-builders

I installed the module on a site where it had not been installed earlier.

I waited for 3 days to check. The ticker is not rolling. All stats remain 0 for all nodes.

With version 1.0.0 of Statistics module, on Drupal 10.3.10 and PHP 8.1.30, I've run the following tests - first without and then with the changes in MR !7 applied:

Clear caches;
Load a page with number of views showing;
Note number of views;
Load a different page;
Reload the first page;
Note number of views.

WITHOUT the MR !7 changes in place, on reloading the first page, the displayed number of views is unchanged from when the page was first loaded. Displayed number of views only increases after clearing caches.

WITH the MR !7 changes in place, on reloading the first page, the displayed number of views is incremented by 1 from when the page was first loaded. Further reloads result in further increments of the displayed number of views - no need to clear caches.

In other words, for me, the changes in MR !7 fix the failure to update issue.

Since there is no documentation on changes required for shifting from core module of Drupal 10.3.0 to Statistics 1.0, I need a confirmation about thsi, please.

Drupal change record says that the following should be removed

# Allow access to Statistics module's custom front controller.
# Copy and adapt this rule to directly execute PHP files in contributed or
# custom modules or to run another PHP application in the same directory.
RewriteCond %{REQUEST_URI} !/core/modules/statistics/statistics\.php$

Now, I have done that. But what should it be replaced with (if at all)?

From memory, all I did to switch from the core Statistics module to the contributed Statistics module was uninstall core Statistics, install contrib Statistics and comment out the highlighted RewriteCond line in .htaccess. I certainly didn't replace the RewriteCond line with anything else.

And for me, MR !7 resolved the count not updating issue.

I'd be keen to see MR !7 committed and a fresh release made.

As statistics is still in core (10.4) I am unhappy that this issue has been moved to contrib.

I am also unhappy at the Drupal policy of targeting the next major release. which I have not upgraded to yet because they have dropped support for statistics.

Actually after upgrading from 10.2 to 10.4 latest patch for 10.3 applies without issue.

Having just updated to version 1.0.1, I am reminded that I need a fix for this issue.

Having manually applied the MR !7 fix, to the 1.0.1 release, the count is once again being incremented and correctly displayed whenever a page is viewed.

It is over a year since a user reported that this wasn't working for them, but no further information has been provided. Can we not agree that the fix at MR !7 resolves this issue and get it committed?

Tested with changes from MR #7

This fixed those issue with caching, LGTM