Add plugin support

Hey,
I have tested your patch. It applies and works. However it adds another step at enabling entity type for recently read (first you have to enable plugin then you have to enable it in list '/admin/config/system/recently-read'). This might be a bit counterintuitive. I've also tried to add poll as plugin. I have created new custom module with Poll class in 'my-new-module/src/Plugin/RecentlyReadType' and it was show in configuration afterwards.

However I did not menage to show recently viewed polls in views block. This might however be separate issue since I didn't find a way to show neither users nor taxonomy_terms which are already recognised via recently read type manager.

Test patch with commerce 2 products. Works as expected.

Tested on three different projects

Thanks for the patch @nkoporec this is just what I am looking for but I can't get it working. I have used composer to install the dev version and added the patch which has gone smoothly, but I don't see how @a.sinitsa has been able to get this working with commerce 2. I don't see "Products" listed in the list of Plugins. Please, can you advise what I am missing?

Hi @mbatterton!
You should create new module Ex. recently_read_products with Commerce_product.php inside recently_read_products/src/Plugin/RecentlyReadType/

with this code:

<?php
namespace Drupal\recently_read\Plugin\recently_read\RecentlyReadType;

use Drupal\recently_read\Plugin\RecentlyReadTypeBase;

/**
 * Product recently read type.
 *
 * @RecentlyReadType(
 *   id = "commerce_product",
 *   label = @Translation("Product"),
 * )
 */
class commerce_product extends RecentlyReadTypeBase {}

@nkoporec and @a.sinitsa thank you, guys. This is exactly what I need thank you for getting back to quickly.

i am unable to apply against 8.x-1.0 :-(

Likewise. Unable to apply this patch.

It looks like this patch needs to be re-rolled against the current 8.x-1.0 version of this module. Changing status to "Needs Work".

@nkoporec My bad. Thank you!

The patch seems to be working, but I can't seem to add the relationship to the views block when the base table is Products.

Am I missing something obvious or the patch doesn't have it yet?

Thanks!

@nkoporec I understood that. I've the module with your patch and created a new plugin module as instructed in #8. This is what I have:

But from what I understood of the module in D8 it's needed to add a relationship "Recently read" like in the default /admin/structure/views/view/recently_read_content: When I try to that with a base table of Products (because my plugin is for Drupal Commerce products) no relationship of that type appears.

Do I need something more in my plugin?

While testing patch #2 and trying to explain it's usage for @introfini, I realized that it does work with some adjustments and quirks, but it is only useful with further development (of plugins), just to fulfill a simple requirement of being able to track ANY Entity Type.
That's why I refactored it in such a way that Administrator can just tick checkboxes in a list of all (content) Entity Types and that's it... no need for custom plugin development. I tested it with core Entity Types (nodes, taxonomies), and also with module-provided Entity Types, for example, Product from commerce module.
I also developed an upgrade path from the 8.x-1.0 version and from the patch #2 version.

I have tested this and looked at the code and everything appears to be in order and working. Thanks, bzoks.

> it's needed to add a relationship "Recently read"
> like in the default /admin/structure/views/view/recently_read_content
After #18 and run /update.php in module` recently_read_content view relationship will be "Broken/missing handler".
But you can add the relationship in any other views.

@nkoporec
Thanks for your great works on this module. I have add you as module maintainer.
You can commit it to the latest code and make new release.

Cheers!

I installed latest dev 8.x-1.1+7-dev. After installing I went to admin/config/system/recently-read/config to uncheck the default Content (node) then checked for Commerce product. I then went to here admin/structure/views/view/recently_read_content/edit/block_1 -> The views relationship is broken.

This patch is not working in Drupal 9.1.0 because in the RecentlyReadRelationship.php the following line of code is using the bundle column but the table actually has the type column. So I request to open the issue again so that the patch can updated and tested.

Code in the patch

$this->query->addWhere('recently_read', "$basetable.bundle", array_filter(array_values($this->options['bundles'])), "IN");

Actual code should be

$this->query->addWhere('recently_read', "$basetable.type", array_filter(array_values($this->options['bundles'])), "IN");