Problem/Motivation
The social_font module provides a UI for site administrators to change the default font used on the site.
The social_activity module displays an activity stream and provides the notification centre for the OpenSocial site.
The two modules are unrelated and work at different parts of the page request. However, social_activity depends on social_font because Drupal's configuration management system incorrectly detects that the field.storage.activity.field_activity_entity configuration depends on social_font.
A site implementing a custom theme, or a subtheme of the socialbase or socialblue themes may want to uninstall social_font because it injects CSS into the page in a manner that makes it difficult to override; but keep social_activity because it provides important functionality. Trying to remove social_font right now takes social_activity with it, which is undesirable:
$ drush pmu social_font
The following extensions will be uninstalled: social_font, social_activity
Do you really want to continue? (y/n): n
$
Proposed resolution
Remove the dependency on social_font from social_activity and its field.storage.activity.field_activity_entity configuration.
Remaining tasks
Convert the patch in #5 into a patch file- Review and feedback
- RTBC and feedback
- Commit and release
User interface changes
None: both modules will continue to work as they did before.
API changes
None.
Data model changes
None.
Release notes snippet
Not applicable (not major).
Original report by Kolin
Steps to reproduce:
drush pmu social_font
The following extensions will be uninstalled: social_font, social_activity
Do you really want to continue? (y/n): n| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2962184-8--social_activity-does-not-need-to-depend-on-social_font.patch | 840 bytes | mparker17 |
Comments
Comment #2
kolin commentedComment #3
jaapjan commentedhttps://github.com/goalgorilla/open_social/pull/1137
Comment #4
jaapjan commentedComment #5
socialnicheguru commentedThis is still need this
patch -p1 < https://github.com/goalgorilla/open_social/pull/1137.patch
patching file modules/social_features/social_activity/config/install/field.storage.activity.field_activity_entity.yml
patching file modules/social_features/social_activity/social_activity.info.yml
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file modules/social_features/social_activity/social_activity.info.yml.rej
patching file modules/social_features/social_activity/social_activity.install
more modules/social_features/social_activity/social_activity.info.yml.rej
--- modules/social_features/social_activity/social_activity.info.yml
+++ modules/social_features/social_activity/social_activity.info.yml
@@ -24,7 +24,6 @@ dependencies:
- search_api:search_api
- social_comment:social_comment
- social_event:social_event
- - social_font:social_font
- social_group:social_group
- social_post:social_post
- social_topic:social_topic
Comment #6
mparker17Here's a patch file that will apply to
8.x-9.x, for use with composer.Comment #7
mparker17Should check off that I completed the first remaining task.
Comment #8
mparker17Here's the patch from #6 rebased onto
8.x-9.x.Comment #9
mparker17This applies to OpenSocial 10
Comment #10
ressinelPR https://github.com/goalgorilla/open_social/pull/3047
Comment #11
tbsiqueiraWill be available on 11.5.x and over