Problem

With the new Group & Visibility section and group widget the default content visibility that you can set at /admin/config/opensocial/visibility is no longer respected. It always defaults to 'community'.

You can test this by going to /admin/config/opensocial/visibility and setting the default visibility to 'public' and then creating a topic.

Furthermore the logic in the SocialGroupSelectorWidget::validateGroupSelection is also flawed. It sends a "checked" command for every option so the last one (community) is always selected even when "public" is the default. You can see this when you first select a group and the visibility is set to group. Then setting the group selection to "None". You'd expect the visibility to go to "Public" but it goes to "Community".

Solution

  • Find out and fix why the default visibility is not respected.
  • Apply the patch of #2 as a workaround for SocialGroupSelectorWidget::validateGroupSelection
CommentFileSizeAuthor
#2 2961728-2.patch1.28 KBkingdutch

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

StatusFileSize
new1.28 KB
jaapjan’s picture

Status: Active » Needs review
kingdutch’s picture

This possibly still needs work because step 1 of the solution wasn't executed.

bramtenhove’s picture

Status: Needs review » Fixed

  • ronaldtebrake committed 0608eea on 8.x-2.x
    #2961728 by ronaldtebrake: Fix default visibility and visibility on ajax...
  • ronaldtebrake committed aaea22f on 8.x-2.x
    #2961728 - Trying some behat test to check default visbility since...
  • ronaldtebrake committed abc3d9f on 8.x-2.x
    #2961728 - Trying some behat test to see if it will accept my fiddeling...
  • ronaldtebrake committed ae8b827 on 8.x-2.x
    #2961728 - Trying some behat test to see if it will accept my fiddeling...
  • 37c94e9 committed on 8.x-2.x
    Merge pull request #969 from goalgorilla/feature/2961728-default-...
  • bramtenhove committed 48985f0 on 8.x-2.x
    #2961728 by bramtenhove: Set the default visibility to community
    
  • bramtenhove committed 54a2fea on 8.x-2.x
    #2961728 by bramtenhove: Remove unneeded and duplicate test step
    
  • bramtenhove committed 6593946 on 8.x-2.x
    #2961728 by bramtenhove: Reset the visibility to community ... not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.