Convert theme to use short array syntax according to new coding standards.

CommentFileSizeAuthor
#6 diff_reroll_2961383_2-6.txt1.14 KBankithashetty
#6 2961383-6.patch5.25 KBankithashetty
#3 Business.png331.53 KBakash.addweb
#2 2961383.patch5.2 KBVidushi Mehta

Comments

Vidushi Mehta created an issue. See original summary.

Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Active » Needs review
StatusFileSize
new 2961383.patch5.2 KB

Adding a patch with the conversion.

akash.addweb’s picture

akash.addweb commented
StatusFileSize
new Business.png331.53 KB

@Vidushi Mehta, Thanks for solving this errors, Now all the errors related to short array index are resolved as per pareview.sh report. PFA

akash.addweb’s picture

akash.addweb commented
Status: Needs review » Reviewed & tested by the community
gauravvvv’s picture

gauravvvv commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch is no longer applying to D8.1

Osls-Air:business osl$ git apply -v 2961383.patch
Checking patch business.theme...
error: while searching for:
  }
  $show_slideshow = theme_get_setting('slideshow_display', 'business');
  if ($vars['is_front'] && $show_slideshow) {
    $vars['slider'] = array();
    for ($i = 1; $i <= SLIDESHOW_COUNT; $i++) {
      $fid = theme_get_setting("slide_image_{$i}", "business");
      $file = \Drupal\file\Entity\File::load($fid[0]);

error: patch failed: business.theme:41
error: business.theme: patch does not apply
ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2961383-6.patch5.25 KB
new diff_reroll_2961383_2-6.txt1.14 KB

Re-rolled the patch in #2, thanks!

  • Gauravmahlawat committed 84902fb on 8.x-1.x 
    Issue #2961383 by ankithashetty, Vidushi Mehta, akash.addweb,...
gauravvvv’s picture

gauravvvv commented
Status: Needs review » Fixed

Thanks, Fixed and committed 84902fb on 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.