Help is missing on module file

CommentFileSizeAuthor
#11 ctoolshelp2.png99.43 KBguilhermevp
#11 ctollshelp1.png18.89 KBguilhermevp
#10 Before .png50.71 KBkomalk
#10 After.png63.77 KBkomalk
#9 2960195-9.patch2.63 KBkomalk
#7 Selection_016.png78.88 KBandrey.troeglazov
#7 Selection_015.png63.63 KBandrey.troeglazov
#4 ctools-Help_is_missing_on_module_file-2960195-4-D8.patch2.62 KBthalles
#3 Help_Page.png115.13 KBAanal.addweb
#3 After_Patch.png25.5 KBAanal.addweb
#3 Before_Patch.png24.19 KBAanal.addweb
#2 help-2960195_2.patch2.65 KBemartoni

Comments

emartoni created an issue. See original summary.

emartoni’s picture

emartoni commented
Assigned: emartoni » Unassigned
Status: Active » Needs review
StatusFileSize
new help-2960195_2.patch2.65 KB

Patch attached!

Best,
Eduardo

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before_Patch.png24.19 KB
new After_Patch.png25.5 KB
new Help_Page.png115.13 KB

@emartoni, Thanks for the patch, I checked it using simplytest.me & it is working fine for me.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new ctools-Help_is_missing_on_module_file-2960195-4-D8.patch2.62 KB

I add blank line on end file

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Category: Bug report » Feature request
amarphule’s picture

amarphule commented

#4 Patch Works for me on PHP-7.3 mySql-5.7 D8.6.15.

andrey.troeglazov’s picture

andrey.troeglazov commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Selection_015.png63.63 KB
new Selection_016.png78.88 KB

Last patch from #4 is working.

chris matthews’s picture

chris matthews commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
Checking patch ctools.module...
error: while searching for:
<?php

/**
 * Implements hook_theme().
 */

error: patch failed: ctools.module:1
error: ctools.module: patch does not apply
komalk’s picture

komalk commented
StatusFileSize
new 2960195-9.patch2.63 KB

Worked on #8.
Re-rolled the patch.

komalk’s picture

komalk commented
Status: Needs work » Needs review
StatusFileSize
new After.png63.77 KB
new Before .png50.71 KB

Attached before and after screenshot for reference.
Review the patch.

guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll
StatusFileSize
new ctollshelp1.png18.89 KB
new ctoolshelp2.png99.43 KB

Patch works as intended.

  • joelpittet committed 3495839 on 8.x-3.x authored by komalk 
    Issue #2960195 by komalk, emartoni, thalles, Aanal.addweb, andrey....
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks all for your help on this, I've committed it for the next release.

Hopefully in the near future we can move to Help Topics:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

apaderno credited dbt102.

apaderno credited shreyakaushik11.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented