Hi,

After updating fron rc7 to rc9, webform templates are not called anymore : see print screen attached.
Thanks for your answer.

Best.

CommentFileSizeAuthor
#4 2959480-3.patch3.21 KBjrockowitz
#2 2959480-2.patch566 bytesjrockowitz
After (rc9).jpg59.01 KBbrulain
Before (rc7).jpg84.92 KBbrulain

Comments

brulain created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 2959480-2.patch566 bytes

I am baffled to why we are seeing this regression.

The attached patch restores the webform.html.twig template.

Status: Needs review » Needs work

The last submitted patch, 2: 2959480-2.patch, failed testing. View results

jrockowitz’s picture

jrockowitz commented
Priority: Normal » Major
Status: Needs work » Needs review
StatusFileSize
new 2959480-3.patch3.21 KB

So this change Webform submission form id now include the source entity type and id and base form id includes the webform id is causing the regression.

The attached patch fixes the issue.

This is a major regression and requires a new release.

bailey86’s picture

bailey86 commented

Hi Jacob,

This hits us as well. Is there any rough idea of releasing this as rc10?

Thanks,

Kevin

jrockowitz’s picture

jrockowitz commented

Can you please review the patch. I can tag a release today or tomorrow.

bailey86’s picture

bailey86 commented

Will do.

What is the Drupal procedure for applying, testing and reporting a patch?

jrockowitz’s picture

jrockowitz commented

Go to the root of the webform module

curl https://www.drupal.org/files/issues/2018-04-09/2959480-3.patch | git apply -

bailey86’s picture

bailey86 commented

https://www.drupal.org/files/issues/2018-04-09/2959480-3.patch

This patch works for us in that the webform now works - this is because the webform.html.twig is being called instead of form.html.twig.

  • jrockowitz committed 3be4e6c on 8.x-5.x 
    Issue #2959480 by jrockowitz, brulain: Template no more called after...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed
jrockowitz’s picture

jrockowitz commented

I tagged a new release.

Release early, release often

Thanks for catching that issue.

bailey86’s picture

bailey86 commented

Thanks Jacob.

brulain’s picture

brulain commented

Thanks a lot for this quick fix and for this marvellous module !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.