Problem/Motivation

Currently to inject facets into views area user require to create block placement (and hide it), then use to add it with non-intuitive interface by providing block id.

Proposed resolution

Add area plugin per search api view to allow display set of configured facets for the view

Remaining tasks

- review implmentation
- clean-up filtering for facet source
- add tests

User interface changes

CommentFileSizeAuthor
#6 2957950-6.patch4.53 KBsvendecabooter
#4 2957950-4.patch4.49 KBandypost
#4 2957950-interdiff-2.txt1.34 KBandypost
#2 2957950-2.patch4.2 KBandypost
area-settings.png21.29 KBandypost
area.png13.57 KBandypost
current.png36.64 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 2957950-2.patch4.2 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented

Just discovered that load multiple does not sort facets according their weight... looking how to fix

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 2957950-interdiff-2.txt1.34 KB
new 2957950-4.patch4.49 KB

Here is sorting & admin label to display enabled facets

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented 
+++ b/src/Plugin/views/area/Facets.php
@@ -0,0 +1,125 @@
+    foreach ($facets as $facet) {
+      if ($facet->getFacetSourceId() === $source) {
+        $options[$facet->id()] = $facet->label();
+      }
+    }

I think we can do this with an array_filter instead, but that is just preference.

As you mentioned in the IS, this also needs tests.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
StatusFileSize
new 2957950-6.patch4.53 KB

Updated the patch in #4 to also work with Views displays other than the "page" display.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Maybe we should try to render the facets as blocks, that would give us the ajax support for free.

hugronaphor’s picture

hugronaphor commented

@chr.fritsch I would really want Facets module to not be tight to Block plugins. But seems like this needs quite a decent refactoring.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Maybe we should try to render the facets as blocks, that would give us the ajax support for free.

That would probably be somewhat easier yeah, especially on maintenance down the line.

@chr.fritsch I would really want Facets module to not be tight to Block plugins. But seems like this needs quite a decent refactoring.

Yeah that's not going to happen any time soon. A big rewrite like this will probably only happen when someone hands me a boatload of money.\

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Related issues: +#3075378: [META] Overview of Facets + Ajax issues, +#3073444: Create views plugins to render facets and summaries in filters and areas
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

I'd propose working on #3073444: Create views plugins to render facets and summaries in filters and areas and closing this. Objections?

swentel’s picture

swentel commented
Status: Needs review » Closed (duplicate)

Indeed, closing this. We made the decision to rip out the old AJAX implementation and go for views plugins completely.
Will move this plugin inside the patch over at #3073444: Create views plugins to render facets and summaries in filters and areas

- actually - do we still need to have an area plugin or not?

andypost’s picture

andypost
he/him
Primary language Russian
commented

Area plugins are more useful when you need to place configurable list of facets for each page