Steps to reproduce:
1. Add a link to the menu with as the path.
(I am doing this in a links.menu.yml file and passing <nolink> as the route)
2. Clear cache and see the items with no link are not behaving appropriately.

It seems like the styling is breaking because the <a> is replaced with a <span>.

Comments

sonfd created an issue. See original summary.

sonfd’s picture

Issue summary: View changes
sonfd’s picture

Issue summary: View changes
energee’s picture

Can you post an image?

sonfd’s picture

StatusFileSize
new22.03 KB

Sure, here's one. You can see that "Add Page" is just up in the middle of nowhere.

I think I looked into this further and traced this issue all the way back to one of the core themes. I wish I would've been responsible and updated this issue, but it was a while ago now and can't remember. I think it would be an issue with the default toolbar and is not something specific to the Adminimal toolbar. I think there are just a bunch of styles that target < a >s specifically. The < nolink > text gets wrapped with < span >, so we could probably update the styles to target both < a > and < span >. I meant to look into it again before now, however I will look again sometime if it's not resolved by then.

energee’s picture

Category: Bug report » Feature request

I would accept a patch for this even tho issue stems from dependency, but moving it out of bugs category.

IreneV’s picture

StatusFileSize
new953 bytes

Patch for issue

IreneV’s picture

Status: Active » Needs review
artsays’s picture

Status: Needs review » Fixed

It works! Great, thank you IreneV

artsays’s picture

  • energee committed da1abfe on 8.x-1.x authored by IreneV
    Issue #2957585 by IreneV, sonfd: Styling breaks down when using...
energee’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.