We need to allow adding website or blog url.

CommentFileSizeAuthor
#12 2956765-12.patch1.77 KBgnuget
#12 2956765-11-12-interdiff.txt662 bytesgnuget
#11 2956765-6-11-interdiff.txt1.14 KBgnuget
#11 2956765-11.patch1.77 KBgnuget
#9 2956765-6-9-interdiff.txt1.14 KBgnuget
#9 2956765-9.patch2.75 KBgnuget
#6 2956765-6.patch1.46 KBgnuget
#6 2956765-5-6-interdiff.txt1.72 KBgnuget
#5 allow_adding_website_url_or_blog-2956765.patch1.45 KBmahmoud-zayed
#4 2956765.patch1.54 KBmahmoud-zayed
#3 2956765-1.patch1.54 KBmahmoud-zayed
#2 2956765-1.patch522 bytesmahmoud-zayed

Comments

mahmoud-eid created an issue. See original summary.

mahmoud-zayed’s picture

mahmoud-zayed commented
Status: Active » Needs review
StatusFileSize
new 2956765-1.patch522 bytes

Here's a patch that add this feature.

mahmoud-zayed’s picture

mahmoud-zayed commented
StatusFileSize
new 2956765-1.patch1.54 KB
mahmoud-zayed’s picture

mahmoud-zayed commented
StatusFileSize
new 2956765.patch1.54 KB
mahmoud-zayed’s picture

mahmoud-zayed commented
StatusFileSize
new allow_adding_website_url_or_blog-2956765.patch1.45 KB

Please use this patch because above patches are missing some code.

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new 2956765-5-6-interdiff.txt1.72 KB
new 2956765-6.patch1.46 KB

This looks great thanks!

I modified a bit your patch because it had a problem with the indentation I also took the liberty to use a more generic icon (instead of dribble) to display the website icon.

Patch attached.

egfrith’s picture

egfrith commented

This patch works for me, and would be very useful.

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

In use and working great!

gnuget’s picture

gnuget
Primary language Spanish
commented
Related issues: +#3090649: Improve Tumblr usability.
StatusFileSize
new 2956765-9.patch2.75 KB
new 2956765-6-9-interdiff.txt1.14 KB

I just create a new version of the patch improving the usability a bit.

It adds the protocol if is not in the url before the validation.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs review
gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new 2956765-11.patch1.77 KB
new 2956765-6-11-interdiff.txt1.14 KB

I uploaed the wrong patch at #9.

New patch.

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new 2956765-11-12-interdiff.txt662 bytes
new 2956765-12.patch1.77 KB

New patch.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.