Right now if the tumblr url is added it must start with http or https if that is not the case an error is displayed which is expected but this could be improved a bit checking the protocol and if is not there then added it before the validation.

Patch attached.

CommentFileSizeAuthor
#3 3090649-3.patch1004 bytesgnuget
#3 3090649-2-3-interdiff.txt657 bytesgnuget
#2 3090649-2.patch1003 bytesgnuget

Comments

gnuget created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3090649-2.patch1003 bytes
gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new 3090649-2-3-interdiff.txt657 bytes
new 3090649-3.patch1004 bytes

New patch.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Closed (works as designed)
mlncn’s picture

mlncn commented
Status: Closed (works as designed) » Active

Could we get some explanation here? It would be a big usability improvement to accept people putting in links in the same way they will see them in most modern browsers and written down in text— `example.com` or `www.example.com`. We know it will be https:// for any modern service. Can we re-open this to not be Tumblr-specific but for any full-URL option?

This module is for general users not just developers so being a bit nicer in the input it accepts is a big deal.