FILE: ...DCO/core/D8/modules/contrib/mailsystem/src/MailsystemManager.php
----------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
----------------------------------------------------------------------
24 | ERROR | [ ] Missing short description in doc comment
59 | ERROR | [x] Short array syntax must be used to define arrays
114 | ERROR | [x] Short array syntax must be used to define arrays
119 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: 'defaults'
124 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
140 | ERROR | [x] Short array syntax must be used to define arrays
156 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
159 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...modules/contrib/mailsystem/src/Tests/MailsystemTestThemeTest.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
31 | ERROR | [x] Missing function doc comment
34 | ERROR | [x] Functions must not contain multiple empty lines in
| | a row; found 2 empty lines
59 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...8/modules/contrib/mailsystem/src/Tests/AdminFormSettingsTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
20 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: 'mailsystem'
187 | ERROR | [x] Expected 1 blank line after function; 0 found
188 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../D8/modules/contrib/mailsystem/src/MailsystemServiceProvider.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 1
16 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
17 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../Projetos/DCO/core/D8/modules/contrib/mailsystem/src/Adapter.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
12 | ERROR | Missing short description in doc comment
17 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------
FILE: ...os/DCO/core/D8/modules/contrib/mailsystem/src/Form/AdminForm.php
----------------------------------------------------------------------
FOUND 26 ERRORS AND 3 WARNINGS AFFECTING 29 LINES
----------------------------------------------------------------------
20 | ERROR | [ ] Missing short description in doc comment
25 | ERROR | [ ] Missing short description in doc comment
30 | ERROR | [ ] Missing short description in doc comment
69 | ERROR | [ ] Public method name "AdminForm::getFormID" is not
| | in lowerCamel format
77 | ERROR | [x] Short array syntax must be used to define arrays
86 | ERROR | [x] Short array syntax must be used to define arrays
96 | ERROR | [x] Short array syntax must be used to define arrays
104 | ERROR | [x] Short array syntax must be used to define arrays
113 | ERROR | [x] Short array syntax must be used to define arrays
122 | ERROR | [x] Short array syntax must be used to define arrays
131 | ERROR | [x] Short array syntax must be used to define arrays
139 | ERROR | [x] Short array syntax must be used to define arrays
145 | ERROR | [x] Short array syntax must be used to define arrays
151 | ERROR | [x] Short array syntax must be used to define arrays
157 | ERROR | [x] Short array syntax must be used to define arrays
164 | ERROR | [x] Short array syntax must be used to define arrays
173 | ERROR | [x] Short array syntax must be used to define arrays
175 | ERROR | [x] Short array syntax must be used to define arrays
194 | ERROR | [x] Short array syntax must be used to define arrays
196 | WARNING | [ ] t() calls should be avoided in classes, use
| | dependency injection and $this->t() instead
199 | ERROR | [x] Short array syntax must be used to define arrays
207 | ERROR | [x] Short array syntax must be used to define arrays
215 | ERROR | [x] Short array syntax must be used to define arrays
262 | WARNING | [ ] Line exceeds 80 characters; contains 82
| | characters
263 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
323 | ERROR | [x] Short array syntax must be used to define arrays
339 | ERROR | [x] Short array syntax must be used to define arrays
341 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: )
362 | ERROR | [x] Additional blank lines found at end of doc
| | comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | code_standard-2956740-7.patch | 36.3 KB | emartoni |
| #6 | readme file change-2.png | 36.51 KB | Aanal.addweb |
| #6 | README file change-1.png | 57.48 KB | Aanal.addweb |
| #6 | file change missing- 16 & 17.png | 41.02 KB | Aanal.addweb |
| #4 | code_standard-2956740-2.patch | 34.8 KB | emartoni |
Comments
Comment #2
emartoni commentedPatch attached!
Best,
Eduardo
Comment #4
emartoni commentedSorry, wrong patch attached!
Best,
Eduardo
Comment #5
emartoni commentedComment #6
Aanal.addweb commented@emartoni, Thanks for all your efforts, Your changes works as per the standard issues shown in Parteview.sh.
I found that you missed to perform some of the standard changes that are shown in Pareview report. Please find my attached screenshot, in which I mentioned the missed points.
Can you please Do the needful.
Comment #7
emartoni commentedHi @dhwani.addweb, how are you?
Screenshot 1 - Can't find this issue. Even after run pareview.
Screenshot 2 - Fixed.
Screenshot 3 - The readme follows the structure proposed by the author of the module. I think it's better to open a separate issue to suggest this updates. What do you think?
Best,
Eduardo
Comment #10
tr commentedThis is a duplicate of #2858676: Fix coding standards violations. Please contribute to that issue if you want to see these things fixed.