I received the following errors from http://jigsaw.w3.org/css-validator/

URI : http://archiveofawesome.net/sites/all/modules/lightbox2/css/lightbox.css?H 

43 	#loading 	Parse Error *left: 0%;
44 	#loading 	Parse error - Unrecognized }
166 	#overlay 	Parse Error opacity=60)
167 	#overlay 	Property -moz-opacity doesn't exist : 0.6
168 	#overlay 	Property -khtml-opacity doesn't exist : 0.6
169 	#overlay 	Property opacity doesn't exist in CSS level 2.1 but exists in [css3] : 0.6

(listing as a bug, though it may also be a support request)
What I'm wondering is if any of these styles are for specific browsers... because if so I'd like to place them in a conditional style sheet so the site validates at least in Firefox.
Thanks in advance for your advice!
:) Scott

Comments

stella’s picture

stella commented
Category: bug » support
Status: Active » Fixed

I've removed all but the "opacity" setting (line 169), from all the lightbox.css files as the browser specific hacks are no longer required. This is because the opacity is now set in the javascript code. I've left the "opacity" line in as it is valid CSS (ver 3). This change will be included in the next dev release, available later today.

Cheers,
Stella

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

stella’s picture

stella commented

Released in Lightbox2 6.x-1.9 and 5.x-2.9.

Cheers,
Stella

j0rd’s picture

j0rd commented

As far as I know the current 6.x-1.9 code still breaks CSS 2.1. Including the site I'm working on where client complains about not validating =(

Take a peek:
http://netleasedgroup.com

Also breaks CSS3 validation:
http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.netlea...

Not sure what kind of hack this is, but perhaps it has a reason I'm un-aware of:

  left: 45%;                                                                                   
  *left: 0%;
Mark Theunissen’s picture

Mark Theunissen commented
Status: Closed (fixed) » Active

Just noticed this isn't fixed. There is still the "*left: 0%;" in lightbox.css.

Is this an intentional hack?

vthirteen’s picture

vthirteen commented

subscribe

j0rd’s picture

j0rd commented

I also just tested a new site with validation yesterday and noticed I'm still failing CSS validation because of lightbox. This issue will be having it's first birthday tomorrow :D

srobert72’s picture

srobert72 commented

Only 1 error remaining in LightBox2 6.x-1.x-dev (2009-Aug-10)

wrong character * in lightbox.css?P line 43

andrewsuth’s picture

andrewsuth commented

+1 to remove it from the CSS module file, unless someone knows better?

It seems to be the usual invalid IE6 hack. I removed the following line from lightbox.css:

*left: 0%;

I have tested it in IE 6, FF 3, Chrome, Opera and Safari and have had no problems so far. Can someone test this thoroughly in all IE versions?

stella’s picture

stella commented
Status: Active » Closed (duplicate)

duplicate of #363038: CSS validation