We currently have custom code to avoid a fatal error when unserializing a search query in \Drupal\search_api\Query\Query::__wakeup(). This now got fixed upstream in #2909164: Fatal error with stub container in DependencySerializationTrait::__wakeup(). As soon as we can depend on this being present (actually, we could even do this now, since it's only relevant for tests anyways – but might as well wait a bit longer) we can remove our custom code dealing with the problem.

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Postponed » Needs review
StatusFileSize
new889 bytes

Come to think of it: since this only affects tests anyways (and failing ones at that), we could have done this way sooner, too.
Anyways, here is the patch.

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Yep, and it was already in 8.4 it seems.

  • drunken monkey committed 86ce327 on 8.x-1.x
    Issue #2955607 by drunken monkey, borisson_: Removed our custom Query::...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Yep, and it was already in 8.4 it seems.

Not in 8.4.0, as far as I can see, so at least we didn't completely botch this. ;)
Anyways, thanks for reviewing! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.