API and documentation to be corrected ("social_media.add_more_social_media" must be replaced by "social_media.add_more_link") [#2955438]

Comment	File	Size	Author
#21	2955438-21.patch	1.31 KB	dhirendra.mishra
#13	2955438-13.patch	1.31 KB	bhanuprakashnani
#6	social_media_diaspora-8.x-1.0-dev.tar_.gz	16.79 KB	Anonymous (not verified)
#4	2955438-4.patch	1.04 KB	bhanuprakashnani

Comment #1

23 March 2018 at 07:46

filipposcarselli created an issue. See original summary.

Log in or register to post comments

Comment #2

bhanuprakashnani commented 23 March 2018 at 07:55

There is no difference between "social_media.add_more_social_media" and "social_media.add_more_social_media". Did I understand it wrong?

Log in or register to post comments

Comment #3

filipposcarselli commented 23 March 2018 at 13:24

Sorry for my mistake. In the documentation "social_media.add_more_social_media" must be replaced by "social_media.add_more_link".
The same in social_media.api.php :

public static function getSubscribedEvents() {
$events = array();
$events['social_media.add_more_social_media'][] = array('addMoreSocialMedia', 39);
$events['social_media.pre_execute'][] = array('pre_executeSocialMedia', 39);
$events['social_media.pre_render'][] = array('pre_rednerSocialMedia', 39);

return $events;
}

public static function getSubscribedEvents() {
$events = array();
$events['social_media.add_more_link'][] = array('addMoreSocialMedia', 39);
$events['social_media.pre_execute'][] = array('pre_executeSocialMedia', 39);
$events['social_media.pre_render'][] = array('pre_rednerSocialMedia', 39);

return $events;
}

Log in or register to post comments

Comment #4

bhanuprakashnani commented 23 March 2018 at 16:58

Assigned:	Unassigned	» bhanuprakashnani
Status:	Active	» Needs review

Status	File	Size
new	2955438-4.patch	1.04 KB

Made the needed changes. Please review.

Log in or register to post comments

Comment #5

Anonymous (not verified) commented 6 April 2018 at 08:09

Using this patch, I was able to create a module that adds Diaspora as a service that can be used for sharing.

I use the following settings:

API URL:
http://sharetodiaspora.github.io/?title=[current-page:title]&url=[curren...

Alternative image link:
/modules/custom/social_media_diaspora/icons/diaspora.svg

Log in or register to post comments

Comment #6

Anonymous (not verified) commented 6 April 2018 at 08:10

Status	File	Size
new	social_media_diaspora-8.x-1.0-dev.tar_.gz	16.79 KB

Log in or register to post comments

Comment #7

Anonymous (not verified) commented 6 April 2018 at 08:11

Title:	documentation to be corrected	» API and documentation to be corrected ("social_media.add_more_social_media" must be replaced by "social_media.add_more_link")
Component:	Documentation	» Code

This is not just about documentation, but an important correction to the API.

Log in or register to post comments

Comment #8

bhanuprakashnani commented 8 April 2018 at 03:45

Review, please?

Log in or register to post comments

Comment #9

bhanuprakashnani commented 14 April 2018 at 03:37

Can someone look forward into this issue?

Log in or register to post comments

Comment #10

msankhala commented 10 May 2018 at 11:40

Issue summary:

View changes

Log in or register to post comments

Comment #11

msankhala commented 10 May 2018 at 11:46

1 file was hidden/shown/deleted

Status	File	Size
hidden	social_media_diaspora-8.x-1.0-dev.tar_.gz	16.79 KB

@Andreas Speck This issue is not the correct place to share about your custom module.

Log in or register to post comments

Comment #12

msankhala commented 10 May 2018 at 11:58

Status:

Needs review

» Needs work

Changes look good. There is one more place where it should be renamed. docblock of addMoreSocialMedia() method in api.php file.

  /**
   * Subscribes to  social_media.add_more_social_media event.
   *
   */
  public function addMoreSocialMedia($event) {

Log in or register to post comments

Comment #13

bhanuprakashnani commented 10 May 2018 at 19:34

Status:

Needs work

» Needs review

Status	File	Size
new	2955438-13.patch	1.31 KB

Changed it where mentioned. Please review and mention if any more changes are to be made. Thank you.

Log in or register to post comments

Comment #14

msankhala commented 11 May 2018 at 05:17

Status:

Needs review

» Reviewed & tested by the community

Changes look good. Patch #13 applies cleanly and fixes the issue with dispatch event social_media.add_more_link documentation.

Log in or register to post comments

Comment #15

bhanuprakashnani commented 27 June 2018 at 03:11

Please give the fixed tag to this issue.

Log in or register to post comments

Comment #16

scuba_fly

Netherlands, Vinkeveen

commented 26 September 2019 at 11:20

Status:

Reviewed & tested by the community

» Needs work

Makes sense to rename this.

Have to look if this changes is backwords compatible since API change was mentioned.

+++ b/social_media.api.php
@@ -17,7 +17,7 @@ class socialMediaSubscriber implements EventSubscriberInterface {
-    $events['social_media.add_more_social_media'][] = array('addMoreSocialMedia', 39);

When fixing an issue we should apply the coding standards. This uses the old array() syntax. We should use the new [] array syntax for drupal 8 modules.